From 1235b0d7b772d4a6763df704ce8c988659713266 Mon Sep 17 00:00:00 2001 From: Konstantin Prokopenko Date: Fri, 5 Sep 2025 15:17:27 +0300 Subject: [PATCH 1/2] Fix error logging for UpdateOffsetsInTransaction --- .../topicreaderinternal/stream_reader_impl.go | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/internal/topic/topicreaderinternal/stream_reader_impl.go b/internal/topic/topicreaderinternal/stream_reader_impl.go index 3d8af5a9f..d5efdb0f4 100644 --- a/internal/topic/topicreaderinternal/stream_reader_impl.go +++ b/internal/topic/topicreaderinternal/stream_reader_impl.go @@ -232,16 +232,17 @@ func (r *topicStreamReaderImpl) commitWithTransaction( req := r.createUpdateOffsetRequest(ctx, batch, tx) updateOffsetInTransactionErr := retry.Retry(ctx, func(ctx context.Context) (err error) { + logCtx := r.cfg.BaseContext + onDone := trace.TopicOnReaderUpdateOffsetsInTransaction( + r.cfg.Trace, + &logCtx, + r.readerID, + r.readConnectionID, + tx.SessionID(), + tx, + ) defer func() { - logCtx := r.cfg.BaseContext - trace.TopicOnReaderUpdateOffsetsInTransaction( - r.cfg.Trace, - &logCtx, - r.readerID, - r.readConnectionID, - tx.SessionID(), - tx, - ) + onDone(err) }() err = r.topicClient.UpdateOffsetsInTransaction(ctx, req) From b6f315ff5b02c4acd48768cfa3f8caf7d4b4c5ea Mon Sep 17 00:00:00 2001 From: Konstantin Prokopenko Date: Fri, 5 Sep 2025 15:41:04 +0300 Subject: [PATCH 2/2] add Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index db89bb58f..27b502bb0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,5 @@ +* Fixed error logging in `topic.UpdateOffsetsInTransaction` + ## v3.115.4 * Supported reusing one IP address and host name after nodes restart