Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong variable name #40

Open
phamquocthinh opened this issue Aug 23, 2018 · 3 comments
Open

Wrong variable name #40

phamquocthinh opened this issue Aug 23, 2018 · 3 comments

Comments

@phamquocthinh
Copy link

image

line 306, please change into return this.essentialValues.sessionid;
@yatsenkolesh
Copy link
Owner

Hello. Make pull request, please.

@emanuelevivoli emanuelevivoli mentioned this issue Sep 15, 2018
Open
Thibaultfq added a commit to Thibaultfq/instagram-nodejs that referenced this issue Oct 21, 2018
@Thibaultfq
Fixing sessionid variable name as proposed in sissue yatsenkolesh#40
2f9f274
@Thibaultfq Thibaultfq mentioned this issue Oct 21, 2018
Merged
Thibaultfq added a commit to Thibaultfq/instagram-nodejs that referenced this issue Oct 21, 2018
@Thibaultfq
Merge pull request #1 from Thibaultfq/Thibaultfq-sessionid-fix
2656d11 
Fixing sessionid variable name as proposed in issue yatsenkolesh#40
@yatsenkolesh
Copy link
Owner

@Thibaultfq do u can to move this commit to the original repo?

@Thibaultfq
Copy link
Contributor

@Thibaultfq do u can to move this commit to the original repo?

You should approve the pull request and merge it. I opened a new one.

yatsenkolesh pushed a commit that referenced this issue Nov 17, 2018
@Thibaultfq @yatsenkolesh
Fixing sessionid variable name as proposed in sissue #40 (#45)
ff03cd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Thibaultfq @phamquocthinh @yatsenkolesh