Skip to content

[BUG] Light Theme Toggle Button Icon Not Visible #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pujaak opened this issue Jan 8, 2025 · 5 comments · Fixed by #36
Closed

[BUG] Light Theme Toggle Button Icon Not Visible #34

pujaak opened this issue Jan 8, 2025 · 5 comments · Fixed by #36
Assignees
Labels
Beginner SWOC Level 1 issue bug Something isn't working good first issue Good for newcomers SWOC officially part of SWOC season 5

Comments

@pujaak
Copy link
Contributor

pujaak commented Jan 8, 2025

Description

Description:
In the website's light theme, the toggle button appears as a plain white box with no visible icon unless hovered over. This is inconsistent with the dark mode toggle button, which displays the moon icon even when not hovered over. The absence of a visible icon in the light theme makes the toggle button look incomplete and less intuitive.

Steps to Reproduce:

  1. Visit the website: [LeetCode Journal](https://leetcode-journal.vercel.app/).
  2. Switch to the light theme using the toggle button.
  3. Observe the toggle button in light mode.

Expected Behavior:
The toggle button in light theme should display a clear and visible icon (e.g., a sun icon) even when not hovered over, similar to the moon icon in dark mode.

Actual Behavior:
The toggle button in light theme appears as a plain white box with no visible icon unless hovered over.

Screenshots

togglr

Any additional information?

Please assign this issue to me. I would like to work on it.

What browser are you seeing the problem on?

Chrome

@pujaak pujaak added the bug Something isn't working label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

👋 Hello @pujaak!

Thank you for raising an issue in the Leetcode Journal project!
Your issue has been logged, and the team will review it shortly.

Issue Handling Checklist:

  • Make sure the issue includes clear steps to reproduce (if applicable).
  • Provide relevant context, screenshots, or logs.
  • Mention if this issue blocks any critical workflows.

Notifications:

We'll get back to you soon. Stay tuned! 🚀

@yashksaini-coder
Copy link
Owner

@pujaak you are assigned and also, while you are at it, improve the toggle button so that it directly changes the theme, not opening a dropdown

@yashksaini-coder yashksaini-coder added good first issue Good for newcomers SWOC officially part of SWOC season 5 Beginner SWOC Level 1 issue labels Jan 8, 2025
@pujaak
Copy link
Contributor Author

pujaak commented Jan 8, 2025

@yashksaini-coder I have removed the need of dropdown, now theme can be changed directly from the toggle button. However, regarding the visibility of the sun icon, when I revisited the website after you assigned me the issue, then the icon in light theme visible. I'm not sure what was the reason then, and what should I do now?

@yashksaini-coder
Copy link
Owner

@yashksaini-coder I have removed the need of dropdown, now theme can be changed directly from the toggle button. However, regarding the visibility of the sun icon, when I revisited the website after you assigned me the issue, then the icon in light theme visible. I'm not sure what was the reason then, and what should I do now?

Recreate the toggle button entirely with good UI style

@pujaak
Copy link
Contributor Author

pujaak commented Jan 8, 2025

Done. I have created the pull request too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner SWOC Level 1 issue bug Something isn't working good first issue Good for newcomers SWOC officially part of SWOC season 5
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants