-
-
Notifications
You must be signed in to change notification settings - Fork 23
[BUG] Light Theme Toggle Button Icon Not Visible #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
👋 Hello @pujaak! Thank you for raising an issue in the Leetcode Journal project! Issue Handling Checklist:
Notifications:
We'll get back to you soon. Stay tuned! 🚀 |
@pujaak you are assigned and also, while you are at it, improve the toggle button so that it directly changes the theme, not opening a dropdown |
@yashksaini-coder I have removed the need of dropdown, now theme can be changed directly from the toggle button. However, regarding the visibility of the sun icon, when I revisited the website after you assigned me the issue, then the icon in light theme visible. I'm not sure what was the reason then, and what should I do now? |
Recreate the toggle button entirely with good UI style |
Done. I have created the pull request too. |
Description
Description:
In the website's light theme, the toggle button appears as a plain white box with no visible icon unless hovered over. This is inconsistent with the dark mode toggle button, which displays the moon icon even when not hovered over. The absence of a visible icon in the light theme makes the toggle button look incomplete and less intuitive.
Steps to Reproduce:
Expected Behavior:
The toggle button in light theme should display a clear and visible icon (e.g., a sun icon) even when not hovered over, similar to the moon icon in dark mode.
Actual Behavior:
The toggle button in light theme appears as a plain white box with no visible icon unless hovered over.
Screenshots
Any additional information?
Please assign this issue to me. I would like to work on it.
What browser are you seeing the problem on?
Chrome
The text was updated successfully, but these errors were encountered: