Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulling this library into yargs #1

Open
3 of 4 tasks
bcoe opened this issue Feb 7, 2017 · 5 comments
Open
3 of 4 tasks

pulling this library into yargs #1

bcoe opened this issue Feb 7, 2017 · 5 comments

Comments

@bcoe
Copy link
Member

bcoe commented Feb 7, 2017

@bcoe
Copy link
Member Author

bcoe commented Feb 7, 2017

@JaKXz regarding the arguments performance discussion; I wonder if there's a second repo we could be releasing that just encapsulates this performant slice step ... maybe this is over-kill.

@bcoe
Copy link
Member Author

bcoe commented Feb 7, 2017

... pretty ugly, but: https://github.com/stefanpenner/sweet-array-slice

@JaKXz
Copy link
Member

JaKXz commented Feb 7, 2017

re: the Array.slice.call(arguments) issue, looking at the babel transpiled code I'm not seeing that call anywhere: https://gist.github.com/JaKXz/c7f077d271a441e8d717008b885019bb

It does arguments[_key] in a for loop where _key is incremented, but I don't think that's terrible since it's essentially just a hash lookup right?

cc @iarna

@iarna
Copy link

iarna commented Feb 8, 2017

Accessing indexes of arguments is fine. IIRC, it's not even a hash lookup because arguments is magic, it's like, a C-level array index access.

@JaKXz
Copy link
Member

JaKXz commented Apr 6, 2017

@bcoe when do you want me to make the transfer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants