Skip to content

Commit ccc3c1d

Browse files
committed
add tickers of read blob valid bytedance#199
1 parent d9567d4 commit ccc3c1d

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

db/version_set.cc

+5
Original file line numberDiff line numberDiff line change
@@ -1275,6 +1275,11 @@ Status Version::fetch_buffer(LazyBuffer* buffer) const {
12751275
context->data[1]);
12761276
uint64_t sequence = context->data[2];
12771277
auto pair = *reinterpret_cast<DependenceMap::value_type*>(context->data[3]);
1278+
if (pair.second->fd.GetNumber() != pair.first) {
1279+
RecordTick(db_statistics_, READ_BLOB_INVALID);
1280+
} else {
1281+
RecordTick(db_statistics_, READ_BLOB_VALID);
1282+
}
12781283
bool value_found = false;
12791284
SequenceNumber context_seq;
12801285
GetContext get_context(cfd_->internal_comparator().user_comparator(), nullptr,

include/rocksdb/statistics.h

+4
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,10 @@ enum Tickers : uint32_t {
258258
GC_TOUCH_FILES,
259259
GC_SKIP_GET_BY_SEQ,
260260
GC_SKIP_GET_BY_FILE,
261+
262+
READ_BLOB_VALID,
263+
READ_BLOB_INVALID,
264+
261265
TICKER_ENUM_MAX
262266
};
263267

monitoring/statistics.cc

+2
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ const std::vector<std::pair<Tickers, std::string>> TickersNameMap = {
139139
{GC_TOUCH_FILES, "rocksdb.num.gc.touch_files"},
140140
{GC_SKIP_GET_BY_SEQ, "rocksdb.num.gc.skip_by_seqno"},
141141
{GC_SKIP_GET_BY_FILE, "rocksdb.num.gc.skip_by_file_meta"},
142+
{READ_BLOB_VALID, "rocksdb.num.read.blob_valid"},
143+
{READ_BLOB_INVALID, "rocksdb.num.read.blob_invalid"},
142144
};
143145

144146
const std::vector<std::pair<Histograms, std::string>> HistogramsNameMap = {

0 commit comments

Comments
 (0)