Allow spaces in releaseName (EmberExperts#16)

* Allow spaces in releaseName

* Add more quotes

* More quotes

* Fix tests

* Fix formatting

* Add newline

* Fix tests

Co-authored-by: Maciej Kwaśniak <[email protected]>

Author: kevinkucharczyk

index.js

@@ -53,22 +53,22 @@ module.exports = {
           : "";
 
         this.log("SENTRY: Creating release...");
-        this.sentryCliExec("releases", `new ${releaseName}`);
+        this.sentryCliExec("releases", `new "${releaseName}"`);
 
         this.log("SENTRY: Assigning commits...");
         this.sentryCliExec(
           "releases",
-          `set-commits ${releaseName} --auto --ignore-missing --ignore-empty`
+          `set-commits "${releaseName}" --auto --ignore-missing --ignore-empty`
         );
 
         this.log("SENTRY: Uploading source maps...");
         this.sentryCliExec(
           "releases",
-          `files ${releaseName} upload-sourcemaps --rewrite ${assetsDir} ${urlPrefix}`
+          `files "${releaseName}" upload-sourcemaps --rewrite ${assetsDir} ${urlPrefix}`
         );
 
         this.log("SENTRY: Finalizing release...");
-        this.sentryCliExec("releases", `finalize ${releaseName}`);
+        this.sentryCliExec("releases", `finalize "${releaseName}"`);
 
         this.log("SENTRY: Release published!...");
       },
@@ -81,7 +81,7 @@ module.exports = {
         this.log("SENTRY: Deploying release...");
         this.sentryCliExec(
           "releases",
-          `deploys ${releaseName} new -e ${environment}`
+          `deploys "${releaseName}" new -e ${environment}`
         );
         this.log("SENTRY: Deployed!");
       },
@@ -91,7 +91,7 @@ module.exports = {
         const releaseName = `${appName}@${this.readConfig("revisionKey")}`;
 
         this.log("SENTRY: Deleting release...");
-        this.sentryCliExec("releases", `delete ${releaseName}`);
+        this.sentryCliExec("releases", `delete "${releaseName}"`);
         this.log("SENTRY: Release deleted!");
       },
 

tests/unit/index-nodetest.js

@@ -165,7 +165,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project new [email protected]@1234567`
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project new "[email protected]@1234567"`
       );
     });
 
@@ -179,7 +179,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project set-commits [email protected]@1234567 --auto --ignore-missing --ignore-empty`
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project set-commits "[email protected]@1234567" --auto --ignore-missing --ignore-empty`
       );
     });
 
@@ -193,7 +193,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project files [email protected]@1234567 upload-sourcemaps --rewrite ${path.join(
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project files "[email protected]@1234567" upload-sourcemaps --rewrite ${path.join(
           'my-dest-dir',
           'assets'
         )} `
@@ -212,7 +212,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project files [email protected]@1234567 upload-sourcemaps --rewrite ${path.join(
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project files "[email protected]@1234567" upload-sourcemaps --rewrite ${path.join(
           'my-dest-dir',
           'assets'
         )} --url-prefix ~/assets`
@@ -229,7 +229,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project finalize [email protected]@1234567`
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project finalize "[email protected]@1234567"`
       );
     });
   });
@@ -245,7 +245,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project deploys [email protected]@1234567 new -e my-production`
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project deploys "[email protected]@1234567" new -e my-production`
       );
     });
   });
@@ -261,7 +261,7 @@ describe('sentry-cli', function () {
 
       this.sinon.assert.calledWithExactly(
         stub,
-        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project delete [email protected]@1234567`
+        `${SENTRY_BIN_PATH}  --auth-token my-auth-token releases --org my-org --project my-project delete "[email protected]@1234567"`
       );
     });
   });