build(deps-dev): Use pipx to install version-constrained build tools; Bump minimum CMake version to 3.23 to support the latest ystdlib-cpp. (#1271)

Co-authored-by: kirkrodrigues <[email protected]>

Author: Bill-hbrhbr

.github/workflows/clp-core-build-macos.yaml

@@ -66,6 +66,12 @@ jobs:
           rm -f /usr/local/bin/pydoc3*
           rm -f /usr/local/bin/python3*
 
+      - name: "Remove preinstalled programs which will conflict with the pipx-installed packages"
+        run: |
+          if brew list --formula cmake >/dev/null 2>&1; then
+            brew uninstall --force cmake
+          fi
+
       - name: "Install dependencies"
         run: "./components/core/tools/scripts/lib_install/macos/install-all.sh"
 

components/core/CMakeLists.txt

@@ -1,4 +1,5 @@
-cmake_minimum_required(VERSION 3.21)
+# ystdlib requires CMake v3.23 or higher
+cmake_minimum_required(VERSION 3.23)
 
 # Toolchain setup must come before the first project() call in the entire CMake buildsystem.
 # If CLP is not the top-level project, the following setup has no effect.

components/core/tools/docker-images/clp-env-base-centos-stream-9/Dockerfile

@@ -5,9 +5,12 @@ WORKDIR /root
 RUN mkdir -p ./tools/scripts/lib_install
 ADD ./tools/scripts/lib_install ./tools/scripts/lib_install
 
-RUN ./tools/scripts/lib_install/centos-stream-9/install-all.sh
+# Set pipx environment vars so that the pipx scripts install into the global locations without
+# passing the `--global` flag.
+ENV PIPX_BIN_DIR=/usr/local/bin
+ENV PIPX_HOME=/opt/pipx
 
-RUN pip3 install --no-cache-dir uv
+RUN ./tools/scripts/lib_install/centos-stream-9/install-all.sh
 
 # Remove cached files
 RUN dnf clean all \

components/core/tools/docker-images/clp-env-base-manylinux_2_28-aarch64/Dockerfile

@@ -5,6 +5,9 @@ WORKDIR /root
 RUN mkdir -p ./tools/scripts/lib_install
 COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
 
+RUN pipx uninstall cmake
+RUN pipx uninstall uv
+
 RUN ./tools/scripts/lib_install/manylinux_2_28/install-all.sh
 
 # Remove cached files

components/core/tools/docker-images/clp-env-base-manylinux_2_28-x86_64/Dockerfile

@@ -5,6 +5,9 @@ WORKDIR /root
 RUN mkdir -p ./tools/scripts/lib_install
 COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
 
+RUN pipx uninstall cmake
+RUN pipx uninstall uv
+
 RUN ./tools/scripts/lib_install/manylinux_2_28/install-all.sh
 
 # Remove cached files

components/core/tools/docker-images/clp-env-base-musllinux_1_2-aarch64/Dockerfile

@@ -5,6 +5,9 @@ WORKDIR /root
 RUN mkdir -p ./tools/scripts/lib_install
 COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
 
+RUN pipx uninstall cmake
+RUN pipx uninstall uv
+
 RUN ./tools/scripts/lib_install/musllinux_1_2/install-all.sh
 
 # Remove cached files

components/core/tools/docker-images/clp-env-base-musllinux_1_2-x86_64/Dockerfile

@@ -5,6 +5,9 @@ WORKDIR /root
 RUN mkdir -p ./tools/scripts/lib_install
 COPY ./tools/scripts/lib_install ./tools/scripts/lib_install
 
+RUN pipx uninstall cmake
+RUN pipx uninstall uv
+
 RUN ./tools/scripts/lib_install/musllinux_1_2/install-all.sh
 
 # Remove cached files

components/core/tools/docker-images/clp-env-base-ubuntu-jammy/Dockerfile

@@ -5,9 +5,12 @@ WORKDIR /root
 RUN mkdir -p ./tools/scripts/lib_install
 ADD ./tools/scripts/lib_install ./tools/scripts/lib_install
 
-RUN ./tools/scripts/lib_install/ubuntu-jammy/install-all.sh
+# Set pipx environment vars so that the pipx scripts install into the global locations without
+# passing the `--global` flag.
+ENV PIPX_BIN_DIR=/usr/local/bin
+ENV PIPX_HOME=/opt/pipx
 
-RUN pip3 install --no-cache-dir uv
+RUN ./tools/scripts/lib_install/ubuntu-jammy/install-all.sh
 
 # Remove cached files
 RUN apt-get clean \

components/core/tools/scripts/lib_install/centos-stream-9/install-all.sh

@@ -1,15 +1,10 @@
 #!/usr/bin/env bash
 
-# Exit on any error
-set -e
+set -o errexit
+set -o nounset
+set -o pipefail
 
-# Error on undefined variable
-set -u
-
-script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
+script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
 
 "${script_dir}/install-prebuilt-packages.sh"
 "${script_dir}/install-packages-from-source.sh"
-
-# TODO: https://github.com/y-scope/clp/issues/795
-"${script_dir}/../check-cmake-version.sh"

components/core/tools/scripts/lib_install/centos-stream-9/install-prebuilt-packages.sh

@@ -1,13 +1,10 @@
 #!/usr/bin/env bash
 
-# Exit on any error
-set -e
-
-# Error on undefined variable
-set -u
+set -o errexit
+set -o nounset
+set -o pipefail
 
 dnf install -y \
-    cmake \
     diffutils \
     gcc-c++ \
     git \
@@ -23,29 +20,10 @@ dnf install -y \
     python3-pip \
     unzip
 
-# Determine architecture for `task` release to install
-rpm_arch=$(rpm --eval "%{_arch}")
-case "$rpm_arch" in
-    "x86_64")
-        task_pkg_arch="amd64"
-        ;;
-    "aarch64")
-        task_pkg_arch="arm64"
-        ;;
-    *)
-        echo "Error: Unsupported architecture - $rpm_arch"
-        exit 1
-        ;;
-esac
+if ! command -v pipx >/dev/null 2>&1; then
+    python3 -m pip install pipx
+fi
 
-# Install `task`
-# NOTE: We lock `task` to version 3.44.0 to avoid https://github.com/y-scope/clp-ffi-js/issues/110
-task_pkg_path="$(mktemp -t --suffix ".rpm" task-pkg.XXXXXXXXXX)"
-curl \
-    --fail \
-    --location \
-    --output "$task_pkg_path" \
-    --show-error \
-    "https://github.com/go-task/task/releases/download/v3.44.0/task_linux_${task_pkg_arch}.rpm"
-dnf install --assumeyes "$task_pkg_path"
-rm "$task_pkg_path"
+# Install remaining packages through pipx
+script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
+"${script_dir}/../pipx-packages/install-all.sh"