Merge pull request #5253 from akphi/patch-1

Tyriar · web-flow · commit 601efc3745c7 · 2025-01-06T09:27:09.000-08:00
bug: properly render the terminal when open() is called again
diff --git a/src/browser/CoreBrowserTerminal.ts b/src/browser/CoreBrowserTerminal.ts
@@ -400,7 +400,7 @@ export class CoreBrowserTerminal extends CoreTerminal implements ITerminal {
     }
 
     // If the terminal is already opened
-    if (this.element?.ownerDocument.defaultView && this._coreBrowserService) {
+    if (this.element?.ownerDocument.defaultView && this._coreBrowserService && this.element?.isConnected) {
       // Adjust the window if needed
       if (this.element.ownerDocument.defaultView !== this._coreBrowserService.window) {
         this._coreBrowserService.window = this.element.ownerDocument.defaultView;

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,7 @@ export class CoreBrowserTerminal extends CoreTerminal implements ITerminal {`
`400`	`400`	`}`
`401`	`401`
`402`	`402`	`// If the terminal is already opened`
`403`		`- if (this.element?.ownerDocument.defaultView && this._coreBrowserService) {`
	`403`	`+ if (this.element?.ownerDocument.defaultView && this._coreBrowserService && this.element?.isConnected) {`
`404`	`404`	`// Adjust the window if needed`
`405`	`405`	`if (this.element.ownerDocument.defaultView !== this._coreBrowserService.window) {`
`406`	`406`	`this._coreBrowserService.window = this.element.ownerDocument.defaultView;`