Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise plugin supports ESLint 8 now #754

Closed
lishaduck opened this issue Jun 23, 2024 · 2 comments
Closed

Promise plugin supports ESLint 8 now #754

lishaduck opened this issue Jun 23, 2024 · 2 comments

Comments

@lishaduck
Copy link

lishaduck commented Jun 23, 2024 •
edited
Loading

xo/config/plugins.cjs

Lines 17 to 18 in ee9f0a3

// Disabled as the plugin doesn't support ESLint 8 yet.
// 'promise',

I'll try to PR sometime, but just FYI, @eslint-community is maintaining eslint-plugin-promise and @mysticatea's plugins (eslint-plugin-eslint-comments)
@lishaduck lishaduck changed the title Promise supports eslint 8 Promise plugin supports ESLint 8 now Jun 23, 2024
@lishaduck
Copy link
Author

Oh, #656 and #699.
I think it's better maintained enough now to be worth considering.

@fregante
Copy link
Member

Duplicate of #699

@fregante fregante marked this as a duplicate of #699 Jul 13, 2024
@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fregante @lishaduck