[d14n] http/grpc test consolidation #1729
Merged
+1,087
−1,571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
changed the title
insipx
force-pushed
the
insipx/d14n-http
branch
2 times, most recently
from
b47b554 to
c045894
Compare
insipx
force-pushed
the
insipx/d14n-http
branch
from
242f27d to
07543ca
Compare
insipx
force-pushed
the
insipx/d14n-http
branch
2 times, most recently
from
c693a67 to
26f8ca0
Compare
insipx
commented
Mar 18, 2025
| @@ -165,11 +158,6 @@ where | |||
| &self, | |||
| request: QueryGroupMessagesRequest, | |||
| ) -> Result<QueryGroupMessagesResponse, Self::Error> { | |||
| self.message_client | |||
There was a problem hiding this comment.
going to remove stats for d14n for now, i think there's a way to do it directly in the client for the d14n api since we have endpoint information in Query and Client request, and the current traits would be tricky to get right with the new Client trait
insipx
force-pushed
the
insipx/d14n-http
branch
from
09a5fda to
db82e1a
Compare
insipx
force-pushed
the
insipx/d14n-http
branch
from
06f6126 to
865ee4f
Compare
codabrink
approved these changes
Mar 18, 2025
neekolas
approved these changes
Mar 18, 2025
insipx
force-pushed
the
insipx/d14n-http
branch
2 times, most recently
from
556b2e9 to
8f99be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC d14n endpoints + http confirmed working with grpc-gateway