Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in stream without panic #1587

Open
insipx opened this issue Feb 3, 2025 · 0 comments
Open

Handle errors in stream without panic #1587

insipx opened this issue Feb 3, 2025 · 0 comments

Comments

@insipx
Copy link
Contributor

insipx commented Feb 3, 2025

2025-02-01T17:23:33.243006Z DEBUG grpc_connect{address="https://grpc.dev.xmtp.network:443"}:Connection{peer=Client}: h2::codec::framed_read: received frame=Data { stream_id: StreamId(23) }
2025-02-01T17:23:33.243257Z DEBUG xmtp_mls::storage::encrypted_store::native: Pulling connection from pool, idle_connections=25, total_connections=25
2025-02-01T17:23:33.243303Z  INFO xmtp_mls::subscriptions::stream_conversations: Trying to process streamed welcome installation_id="acf05b6053643a7ec1edf76eb9a1297194d184807e2bad1b4a6d13a8a586a88a" welcome_id=346388
2025-02-01T17:23:33.243313Z DEBUG xmtp_mls::storage::encrypted_store: Transaction async beginning
2025-02-01T17:23:33.243334Z  INFO xmtp_mls::groups: Trying to decrypt welcome
2025-02-01T17:23:33.243343Z DEBUG xmtp_mls::storage::sql_key_store: read KeyPackageReferences
2025-02-01T17:23:33.244058Z DEBUG xmtp_mls::storage::sql_key_store: read KeyPackage
2025-02-01T17:23:33.244742Z DEBUG xmtp_mls::storage::sql_key_store: read KeyPackage
2025-02-01T17:23:33.254034Z DEBUG xmtp_mls::storage::sql_key_store: write Tree
2025-02-01T17:23:33.258942Z DEBUG xmtp_mls::storage::sql_key_store: write ConfirmationTag
2025-02-01T17:23:33.258995Z DEBUG xmtp_mls::storage::sql_key_store: write GroupContext
2025-02-01T17:23:33.259011Z DEBUG xmtp_mls::storage::sql_key_store: write InterimTranscriptHash
2025-02-01T17:23:33.259559Z  INFO xmtp_mls::groups: Creating from welcome
2025-02-01T17:23:33.259570Z DEBUG xmtp_mls::storage::sql_key_store: read KeyPackage
2025-02-01T17:23:33.263428Z DEBUG xmtp_mls::storage::sql_key_store: write Tree
2025-02-01T17:23:33.263479Z DEBUG xmtp_mls::storage::sql_key_store: write ConfirmationTag
2025-02-01T17:23:33.263492Z DEBUG xmtp_mls::storage::sql_key_store: write GroupContext
2025-02-01T17:23:33.263499Z DEBUG xmtp_mls::storage::sql_key_store: write InterimTranscriptHash
2025-02-01T17:23:33.263582Z DEBUG xmtp_mls::storage::sql_key_store: Writing encryption epoch key pairs
2025-02-01T17:23:33.263586Z DEBUG xmtp_mls::storage::sql_key_store: write EpochKeyPairs
2025-02-01T17:23:33.263600Z DEBUG xmtp_mls::storage::sql_key_store: write Tree
2025-02-01T17:23:33.263607Z DEBUG xmtp_mls::storage::sql_key_store: write ConfirmationTag
2025-02-01T17:23:33.263615Z DEBUG xmtp_mls::storage::sql_key_store: write GroupContext
2025-02-01T17:23:33.263621Z DEBUG xmtp_mls::storage::sql_key_store: write InterimTranscriptHash
2025-02-01T17:23:33.263628Z DEBUG xmtp_mls::storage::sql_key_store: write EpochSecrets
2025-02-01T17:23:33.263633Z DEBUG xmtp_mls::storage::sql_key_store: write OwnLeafNodeIndex
2025-02-01T17:23:33.263643Z DEBUG xmtp_mls::storage::sql_key_store: write MessageSecrets
2025-02-01T17:23:33.263648Z DEBUG xmtp_mls::storage::sql_key_store: write ResumptionPskStore
2025-02-01T17:23:33.263654Z DEBUG xmtp_mls::storage::sql_key_store: write MlsGroupJoinConfig
2025-02-01T17:23:33.263659Z DEBUG xmtp_mls::storage::sql_key_store: write GroupState
2025-02-01T17:23:33.263708Z DEBUG xmtp_mls::storage::encrypted_store: Transaction async being rolled back
2025-02-01T17:23:33.263759Z  INFO xmtp_mls::storage::encrypted_store: error is not retryable. Generic("Invalid permissions for DM group"):generic: Invalid permissions for DM group
2025-02-01T17:23:33.263765Z  INFO xmtp_mls::subscriptions::stream_conversations: Processing welcome failed, trying to load existing..
thread 'tokio-runtime-worker' panicked at /Users/runner/work/libxmtp/libxmtp/xmtp_mls/src/subscriptions/stream_conversations.rs:335:78:
`async fn` resumed after completion
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

if a stream encounters an error, it should return it to the caller rather than panicking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant