Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in new extensions? #738

Open
Procrat opened this issue Jul 26, 2022 · 6 comments
Open

Interest in new extensions? #738

Procrat opened this issue Jul 26, 2022 · 6 comments

Comments

@Procrat
Copy link

Procrat commented Jul 26, 2022

Prompted by an issue on of the repos of my XMonad extensions, I was curious to hear if there would be any interest in including any of them into xmonad-contrib.

I have these:

@TheMC47
Copy link
Member

TheMC47 commented Jul 26, 2022

PRs are very much welcome 🎉

@slotThe
Copy link
Member

slotThe commented Jul 28, 2022

Yes, contributions are always welcome and these modules look quite nice! A few suggestions for making PRs:

I'm not quite sure how this differs from X.L.LayoutHints or X.L.HintedTile, so including that in the PR would make reviewing easier.

In the description you mention X.A.DynamicWorkspaceGroups but I'm not not 100% sure what the differences are between the two modules. Would be a great thing to get some elaboration on.

This could probably live inside X.L.Spacing as an alternative layout instead of getting its own module.

@yuuyins
Copy link

yuuyins commented Aug 4, 2022

In the description you mention X.A.DynamicWorkspaceGroups but I'm not not 100% sure what the differences are between the two modules. Would be a great thing to get some elaboration on.

@slotThe

As far as I know, there isn't really another extension like this. It may be vaguely related to X.A.Plane, X.A.DynamicWorkspaceGroups and X.L.IndependentScreens.

The most important difference between those extensions and this one is how the workspaces are internally handled. Most extensions manipulate the workspaces that XMonad keeps track of internally. This extension leaves those workspace sets completely intact, but just switches to completely other ones. One of the advantages is that this means that all your key bindings and extensions that manage workspaces can remain intact!
---https://github.com/Procrat/xmonad-contexts#similar-extensions

@slotThe
Copy link
Member

slotThe commented Aug 5, 2022 via email

@Procrat
Copy link
Author

Procrat commented Aug 5, 2022

All right, that's all good to know!

It's been about six years since I wrote these and I have no experience with the other modules, but I'll try to answer some questions about the difference with those other ones:

  • XMonad.Layout.PseudoTiling vs X.L.LayoutHints: I use these layout modifiers in combination. In terms of the WM_NORMAL_HINTS property, LayoutHints applies everything but the base size and PseudoTiling applies just the base size.
  • XMonad.Layout.PseudoTiling vs X.L.HintedTile: HintedTile is a layout, whereas PseudoTiling is just a layout modifier which makes no assumptions about how space allocation for windows will happen. It will only use part of the allotted space according to its layout hints.
  • XMonad.Actions.Contexts vs X.A.DynamicWorkspaceGroups: IIUC, DynamicWorkspaceGroups is for putting sets of workspaces on screens. Everything else that interacts with workspaces, like your bar, treats them as if they're all there (but perhaps on multiple screens). Contexts completely hides all workspaces and switches them out with a fresh set. So your bar won't show your initial set of workspaces at all until you switch back.
  • XMonad.Actions.Contexts vs X.L.IndependentScreens: Similar to the one above, I think this is also just a way to have a separate set of workspaces for each screen.

Just to set some realistic expectations, I'm currently quite busy with other things in my life and this is very low on my priority list. Since I wrote these about six years ago and probably require a bit of clean up and documentation to bring them up to the standards of xmonad-contrib, it might take a while before I turn them into a PR.

If you, @yuuyins, or anyone else wants it sooner, feel free to do so!

@slotThe
Copy link
Member

slotThe commented Oct 30, 2023

@Procrat friendly ping, in case you are still interested in this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants