Fix some PMD problems and suppress the rest and add it to issues

AB-xdev · AB-xdev · commit 97bbd1f3eebd · 2025-10-10T11:06:17.000+02:00
diff --git a/bzst-dip-java-client/pom.xml b/bzst-dip-java-client/pom.xml
@@ -550,7 +550,7 @@
 							</rulesets>
 							<!-- All code is auto-generated -->
 							<excludes>
-								<exclude>**/**</exclude>
+								<exclude>software/xdev/bzst/dip/client/generated/**</exclude>
 							</excludes>
 						</configuration>
 						<dependencies>
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/configuration/TaxNumberValidator.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/configuration/TaxNumberValidator.java
@@ -45,6 +45,8 @@ public final class TaxNumberValidator
 	 */
 	public static final int IDNR_CHECKSUM_LENGTH = 1;
 	
+	private static final Pattern TAX_NUMBER_DIGITS_CHECK_PATTERN = Pattern.compile("^[1-9][0-9]{10}$");
+	private static final Pattern ID_NUMBER_DIGITS_CHECK_PATTERN = Pattern.compile("^[1-9][0-9]{9}$");
 	private static final Pattern PATTERN_3_DIGITS_SEQUENCE = Pattern.compile("(.)\\1\\1");
 	public static final int SIZE_FOR_TRIPLETS_ALLOWED = 8;
 	public static final int SIZE_FOR_DOUBLET_ALLOWED = 9;
@@ -74,7 +76,7 @@ public static void validateTaxNumber(final String taxNumber)
 		}
 		
 		// digits only, no leading zero
-		if(!taxNumber.matches("^[1-9][0-9]{10}$"))
+		if(!TAX_NUMBER_DIGITS_CHECK_PATTERN.matcher(taxNumber).matches())
 		{
 			throw new TaxNumberException(taxNumber);
 		}
@@ -99,11 +101,10 @@ public static void validateTaxNumber(final String taxNumber)
 	 */
 	private static boolean doValidateIdNr(final String taxNumber)
 	{
-		
 		Objects.requireNonNull(taxNumber);
 		
 		// 10-digits, no leading zero.
-		if(!taxNumber.matches("^[1-9][0-9]{9}$"))
+		if(!ID_NUMBER_DIGITS_CHECK_PATTERN.matcher(taxNumber).matches())
 		{
 			return false;
 		}
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/message/cesop/BzstCesopPaymentDataBody.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/message/cesop/BzstCesopPaymentDataBody.java
@@ -72,6 +72,7 @@ public PaymentDataBodyType toXmlType() throws DatatypeConfigurationException
 		return paymentDataBodyType;
 	}
 	
+	@SuppressWarnings("PMD.ReplaceJavaUtilCalendar")
 	private List<ReportedPayeeType> convertToReportedPayeesType() throws DatatypeConfigurationException
 	{
 		final List<ReportedPayeeType> reportedPayeeTypes = new ArrayList<>();
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/message/dac7/BzstDipCountryCode.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/message/dac7/BzstDipCountryCode.java
@@ -1282,6 +1282,7 @@ public enum BzstDipCountryCode
 	 */
 	XX;
 	
+	@SuppressWarnings("PMD.NPathComplexity")
 	public CountryCodeType toXmlType()
 	{
 		return switch(this)
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/message/dac7/BzstDipSingleTransferResult.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/model/message/dac7/BzstDipSingleTransferResult.java
@@ -16,6 +16,9 @@
 package software.xdev.bzst.dip.client.model.message.dac7;
 
 import java.util.Arrays;
+import java.util.Map;
+import java.util.function.Function;
+import java.util.stream.Collectors;
 
 
 public record BzstDipSingleTransferResult(String transferNumber, int httpStatusCode)
@@ -30,6 +33,10 @@ public enum StatusCodeMeaning
 		INTERNER_FEHLER(500),
 		UNDEFINIERT(-1);
 		
+		private static final Map<Integer, StatusCodeMeaning> CODE_TO_MEANING =
+			Arrays.stream(StatusCodeMeaning.values())
+				.collect(Collectors.toMap(s -> s.httpStatusCode, Function.identity()));
+		
 		private final int httpStatusCode;
 		
 		StatusCodeMeaning(final int httpStatusCode)
@@ -39,9 +46,7 @@ public enum StatusCodeMeaning
 		
 		public static StatusCodeMeaning getMeaningFromStatusCode(final int httpStatusCode)
 		{
-			return Arrays.stream(StatusCodeMeaning.values()).filter(
-				meaning -> meaning.httpStatusCode == httpStatusCode
-			).findFirst().orElseGet(() -> UNDEFINIERT);
+			return CODE_TO_MEANING.getOrDefault(httpStatusCode, UNDEFINIERT);
 		}
 	}
 	
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/signing/XmlSigner.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/signing/XmlSigner.java
@@ -82,11 +82,15 @@ public XmlSigner(final SigningProvider certAndKeyProvider)
 	 *
 	 * @return the signed xml document as string
 	 */
+	@SuppressWarnings("checkstyle:MagicNumber")
 	public String signXMLDocument(final String unsignedXmlString)
 	{
-		try(final ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-			final ByteArrayInputStream unsignedXmlByteArrayInputStream =
-				new ByteArrayInputStream(unsignedXmlString.getBytes(StandardCharsets.UTF_8)))
+		final byte[] unsignedXmlStringBytes = unsignedXmlString.getBytes(StandardCharsets.UTF_8);
+		try(final ByteArrayInputStream unsignedXmlByteArrayInputStream =
+			new ByteArrayInputStream(unsignedXmlStringBytes);
+			// Output needs at least the size of input + ~3000bytes overhead
+			final ByteArrayOutputStream outputStream = new ByteArrayOutputStream(
+				unsignedXmlStringBytes.length + 4096))
 		{
 			final DocumentBuilderFactory dbf = DocumentBuilderFactoryNoExternalEntities.newInstance();
 			dbf.setNamespaceAware(true);
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/webclient/BearerTokenRequester.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/webclient/BearerTokenRequester.java
@@ -93,6 +93,7 @@ public String getAccessTokenWithBearerPrefix()
 		return BEARER_STRING + this.getAccessToken();
 	}
 	
+	@SuppressWarnings("PMD.ReplaceJavaUtilDate")
 	private String createRequestToken()
 	{
 		LOGGER.debug("Creating jwt token...");
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/ReportableSellerCreator.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/ReportableSellerCreator.java
@@ -50,7 +50,10 @@
 public class ReportableSellerCreator
 {
 	private static final Logger LOGGER = LoggerFactory.getLogger(ReportableSellerCreator.class);
+	
 	public static final String NULL_STRING = "NULL";
+	private static final DateTimeFormatter BIRTH_DATE_DTF = DateTimeFormatter.ofPattern("yyyy-MM-dd");
+	
 	private final BzstDipConfiguration configuration;
 	
 	public ReportableSellerCreator(final BzstDipConfiguration configuration)
@@ -219,7 +222,7 @@ private static ReportableSellerType.Identity createIdentity(
 					createNamePerson(firstName, lastName),
 					addressFixType,
 					legalAddressTypeEnumType,
-					LocalDate.parse(birthDate, DateTimeFormatter.ofPattern("yyyy-MM-dd"))
+					LocalDate.parse(birthDate, BIRTH_DATE_DTF)
 				)
 			);
 		}
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/XMLDocumentBodyCreator.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/XMLDocumentBodyCreator.java
@@ -133,7 +133,7 @@ private Object createData(
 		return dataType;
 	}
 	
-	@SuppressWarnings("PMD.UnusedFormalParameter") // TODO Needs to be resolved!
+	@SuppressWarnings("PMD.UnusedFormalParameter")
 	private Object createData(
 		final PaymentDataBodyType paymentDataBodyType) throws DatatypeConfigurationException
 	{
@@ -258,6 +258,7 @@ protected static AddressType createAddress(
 		return addressType;
 	}
 	
+	@SuppressWarnings("PMD.ReplaceJavaUtilCalendar")
 	private software.xdev.bzst.dip.client.xmldocument.model.cesop.MessageSpecType createMessageSpecCesop()
 		throws DatatypeConfigurationException
 	{
diff --git a/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/XMLDocumentCreator.java b/bzst-dip-java-client/src/main/java/software/xdev/bzst/dip/client/xmldocument/XMLDocumentCreator.java
@@ -89,18 +89,21 @@ public class XMLDocumentCreator
 	 * </p>
 	 */
 	private static final String DPI_XML_XSD = "DPIXML_v1.0.xsd";
+	private static final DateTimeFormatter XML_GREG_CAL_DTF = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss");
+	
 	private final BzstDipConfiguration configuration;
 	
 	public XMLDocumentCreator(final BzstDipConfiguration configuration)
 	{
 		this.configuration = configuration;
 	}
 	
+	@SuppressWarnings("checkstyle:MagicNumber")
 	public String buildXMLDocument(
 		final List<CorrectableReportableSellerType> correctableReportableSellerTypes,
 		final CorrectablePlatformOperatorType correctablePlatformOperatorType)
 	{
-		try(final StringWriter sw = new StringWriter())
+		try(final StringWriter sw = new StringWriter(4096))
 		{
 			final Marshaller jaxbMarshaller = createMarshaller();
 			final DipType dipType = this.buildRootElement(
@@ -121,10 +124,11 @@ public String buildXMLDocument(
 		}
 	}
 	
+	@SuppressWarnings("checkstyle:MagicNumber")
 	public String buildXMLDocument(
 		final PaymentDataBodyType paymentDataBodyType)
 	{
-		try(final StringWriter sw = new StringWriter())
+		try(final StringWriter sw = new StringWriter(4096))
 		{
 			final Marshaller jaxbMarshaller = createMarshaller();
 			final DipType dipType = this.buildRootElement(
@@ -263,8 +267,7 @@ public static XMLGregorianCalendar parseLocalDateToXMLGregorianCalendarDateTime(
 	{
 		try
 		{
-			return DatatypeFactory.newInstance().newXMLGregorianCalendar(
-				localDateTime.format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss")));
+			return DatatypeFactory.newInstance().newXMLGregorianCalendar(localDateTime.format(XML_GREG_CAL_DTF));
 		}
 		catch(final DatatypeConfigurationException e)
 		{

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,8 @@ public final class TaxNumberValidator`
`45`	`45`	`*/`
`46`	`46`	`public static final int IDNR_CHECKSUM_LENGTH = 1;`
`47`	`47`
	`48`	`+ private static final Pattern TAX_NUMBER_DIGITS_CHECK_PATTERN = Pattern.compile("^[1-9][0-9]{10}$");`
	`49`	`+ private static final Pattern ID_NUMBER_DIGITS_CHECK_PATTERN = Pattern.compile("^[1-9][0-9]{9}$");`
`48`	`50`	`private static final Pattern PATTERN_3_DIGITS_SEQUENCE = Pattern.compile("(.)\\1\\1");`
`49`	`51`	`public static final int SIZE_FOR_TRIPLETS_ALLOWED = 8;`
`50`	`52`	`public static final int SIZE_FOR_DOUBLET_ALLOWED = 9;`
`@@ -74,7 +76,7 @@ public static void validateTaxNumber(final String taxNumber)`
`74`	`76`	`}`
`75`	`77`
`76`	`78`	`// digits only, no leading zero`
`77`		`- if(!taxNumber.matches("^[1-9][0-9]{10}$"))`
	`79`	`+ if(!TAX_NUMBER_DIGITS_CHECK_PATTERN.matcher(taxNumber).matches())`
`78`	`80`	`{`
`79`	`81`	`throw new TaxNumberException(taxNumber);`
`80`	`82`	`}`
`@@ -99,11 +101,10 @@ public static void validateTaxNumber(final String taxNumber)`
`99`	`101`	`*/`
`100`	`102`	`private static boolean doValidateIdNr(final String taxNumber)`
`101`	`103`	`{`
`102`		`-`
`103`	`104`	`Objects.requireNonNull(taxNumber);`
`104`	`105`
`105`	`106`	`// 10-digits, no leading zero.`
`106`		`- if(!taxNumber.matches("^[1-9][0-9]{9}$"))`
	`107`	`+ if(!ID_NUMBER_DIGITS_CHECK_PATTERN.matcher(taxNumber).matches())`
`107`	`108`	`{`
`108`	`109`	`return false;`
`109`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ public PaymentDataBodyType toXmlType() throws DatatypeConfigurationException`
`72`	`72`	`return paymentDataBodyType;`
`73`	`73`	`}`
`74`	`74`
	`75`	`+ @SuppressWarnings("PMD.ReplaceJavaUtilCalendar")`
`75`	`76`	`private List<ReportedPayeeType> convertToReportedPayeesType() throws DatatypeConfigurationException`
`76`	`77`	`{`
`77`	`78`	`final List<ReportedPayeeType> reportedPayeeTypes = new ArrayList<>();`
Original file line number	Diff line number	Diff line change
`@@ -1282,6 +1282,7 @@ public enum BzstDipCountryCode`
`1282`	`1282`	`*/`
`1283`	`1283`	`XX;`
`1284`	`1284`
	`1285`	`+ @SuppressWarnings("PMD.NPathComplexity")`
`1285`	`1286`	`public CountryCodeType toXmlType()`
`1286`	`1287`	`{`
`1287`	`1288`	`return switch(this)`
Original file line number	Diff line number	Diff line change
`@@ -82,11 +82,15 @@ public XmlSigner(final SigningProvider certAndKeyProvider)`
`82`	`82`	`*`
`83`	`83`	`* @return the signed xml document as string`
`84`	`84`	`*/`
	`85`	`+ @SuppressWarnings("checkstyle:MagicNumber")`
`85`	`86`	`public String signXMLDocument(final String unsignedXmlString)`
`86`	`87`	`{`
`87`		`- try(final ByteArrayOutputStream outputStream = new ByteArrayOutputStream();`
`88`		`- final ByteArrayInputStream unsignedXmlByteArrayInputStream =`
`89`		`- new ByteArrayInputStream(unsignedXmlString.getBytes(StandardCharsets.UTF_8)))`
	`88`	`+ final byte[] unsignedXmlStringBytes = unsignedXmlString.getBytes(StandardCharsets.UTF_8);`
	`89`	`+ try(final ByteArrayInputStream unsignedXmlByteArrayInputStream =`
	`90`	`+ new ByteArrayInputStream(unsignedXmlStringBytes);`
	`91`	`+ // Output needs at least the size of input + ~3000bytes overhead`
	`92`	`+ final ByteArrayOutputStream outputStream = new ByteArrayOutputStream(`
	`93`	`+ unsignedXmlStringBytes.length + 4096))`
`90`	`94`	`{`
`91`	`95`	`final DocumentBuilderFactory dbf = DocumentBuilderFactoryNoExternalEntities.newInstance();`
`92`	`96`	`dbf.setNamespaceAware(true);`
Original file line number	Diff line number	Diff line change
`@@ -93,6 +93,7 @@ public String getAccessTokenWithBearerPrefix()`
`93`	`93`	`return BEARER_STRING + this.getAccessToken();`
`94`	`94`	`}`
`95`	`95`
	`96`	`+ @SuppressWarnings("PMD.ReplaceJavaUtilDate")`
`96`	`97`	`private String createRequestToken()`
`97`	`98`	`{`
`98`	`99`	`LOGGER.debug("Creating jwt token...");`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,10 @@`
`50`	`50`	`public class ReportableSellerCreator`
`51`	`51`	`{`
`52`	`52`	`private static final Logger LOGGER = LoggerFactory.getLogger(ReportableSellerCreator.class);`
	`53`	`+`
`53`	`54`	`public static final String NULL_STRING = "NULL";`
	`55`	`+ private static final DateTimeFormatter BIRTH_DATE_DTF = DateTimeFormatter.ofPattern("yyyy-MM-dd");`
	`56`	`+`
`54`	`57`	`private final BzstDipConfiguration configuration;`
`55`	`58`
`56`	`59`	`public ReportableSellerCreator(final BzstDipConfiguration configuration)`
`@@ -219,7 +222,7 @@ private static ReportableSellerType.Identity createIdentity(`
`219`	`222`	`createNamePerson(firstName, lastName),`
`220`	`223`	`addressFixType,`
`221`	`224`	`legalAddressTypeEnumType,`
`222`		`- LocalDate.parse(birthDate, DateTimeFormatter.ofPattern("yyyy-MM-dd"))`
	`225`	`+ LocalDate.parse(birthDate, BIRTH_DATE_DTF)`
`223`	`226`	`)`
`224`	`227`	`);`
`225`	`228`	`}`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ private Object createData(`
`133`	`133`	`return dataType;`
`134`	`134`	`}`
`135`	`135`
`136`		`- @SuppressWarnings("PMD.UnusedFormalParameter") // TODO Needs to be resolved!`
	`136`	`+ @SuppressWarnings("PMD.UnusedFormalParameter")`
`137`	`137`	`private Object createData(`
`138`	`138`	`final PaymentDataBodyType paymentDataBodyType) throws DatatypeConfigurationException`
`139`	`139`	`{`
`@@ -258,6 +258,7 @@ protected static AddressType createAddress(`
`258`	`258`	`return addressType;`
`259`	`259`	`}`
`260`	`260`
	`261`	`+ @SuppressWarnings("PMD.ReplaceJavaUtilCalendar")`
`261`	`262`	`private software.xdev.bzst.dip.client.xmldocument.model.cesop.MessageSpecType createMessageSpecCesop()`
`262`	`263`	`throws DatatypeConfigurationException`
`263`	`264`	`{`
Original file line number	Diff line number	Diff line change
`@@ -89,18 +89,21 @@ public class XMLDocumentCreator`
`89`	`89`	`* </p>`
`90`	`90`	`*/`
`91`	`91`	`private static final String DPI_XML_XSD = "DPIXML_v1.0.xsd";`
	`92`	`+ private static final DateTimeFormatter XML_GREG_CAL_DTF = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss");`
	`93`	`+`
`92`	`94`	`private final BzstDipConfiguration configuration;`
`93`	`95`
`94`	`96`	`public XMLDocumentCreator(final BzstDipConfiguration configuration)`
`95`	`97`	`{`
`96`	`98`	`this.configuration = configuration;`
`97`	`99`	`}`
`98`	`100`
	`101`	`+ @SuppressWarnings("checkstyle:MagicNumber")`
`99`	`102`	`public String buildXMLDocument(`
`100`	`103`	`final List<CorrectableReportableSellerType> correctableReportableSellerTypes,`
`101`	`104`	`final CorrectablePlatformOperatorType correctablePlatformOperatorType)`
`102`	`105`	`{`
`103`		`- try(final StringWriter sw = new StringWriter())`
	`106`	`+ try(final StringWriter sw = new StringWriter(4096))`
`104`	`107`	`{`
`105`	`108`	`final Marshaller jaxbMarshaller = createMarshaller();`
`106`	`109`	`final DipType dipType = this.buildRootElement(`
`@@ -121,10 +124,11 @@ public String buildXMLDocument(`
`121`	`124`	`}`
`122`	`125`	`}`
`123`	`126`
	`127`	`+ @SuppressWarnings("checkstyle:MagicNumber")`
`124`	`128`	`public String buildXMLDocument(`
`125`	`129`	`final PaymentDataBodyType paymentDataBodyType)`
`126`	`130`	`{`
`127`		`- try(final StringWriter sw = new StringWriter())`
	`131`	`+ try(final StringWriter sw = new StringWriter(4096))`
`128`	`132`	`{`
`129`	`133`	`final Marshaller jaxbMarshaller = createMarshaller();`
`130`	`134`	`final DipType dipType = this.buildRootElement(`
`@@ -263,8 +267,7 @@ public static XMLGregorianCalendar parseLocalDateToXMLGregorianCalendarDateTime(`
`263`	`267`	`{`
`264`	`268`	`try`
`265`	`269`	`{`
`266`		`- return DatatypeFactory.newInstance().newXMLGregorianCalendar(`
`267`		`- localDateTime.format(DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss")));`
	`270`	`+ return DatatypeFactory.newInstance().newXMLGregorianCalendar(localDateTime.format(XML_GREG_CAL_DTF));`
`268`	`271`	`}`
`269`	`272`	`catch(final DatatypeConfigurationException e)`
`270`	`273`	`{`