From e30bde4a78297e40a5629a850a8552218a4b09c5 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Tue, 12 Sep 2023 16:59:41 -0400 Subject: [PATCH 1/2] Remove no-lockfile --- action.yml | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/action.yml b/action.yml index 4b23088..7ff8ff9 100644 --- a/action.yml +++ b/action.yml @@ -15,10 +15,6 @@ inputs: pnpm-version: description: 'Override the default pnpm version, which defaults to the latest 8.x' required: false - no-lockfile: - description: 'When testing with floating dependencies, the lockfile will need to be ignored. Enabling this deletes the lockfile before running pnpm install. This is safe as long as further action steps do not commit the change' - required: false - default: false args: description: 'Directly pass args to pnpm' required: false @@ -99,19 +95,6 @@ runs: echo "version=$__resolved_version__" >> $GITHUB_OUTPUT - - # It turns out that pnpm does have a flag for this, - # but it's not documented on the website, - # and there is active desire to *not* document on the website. - # - # However, `pnpm install --help` provides the information that was needed for this step to have been avoided. - - name: 'Remove lockfile' - shell: 'bash' - run: | - echo "Detected option --no-lockfile. Lockfile will be deleted before install." - rm -f pnpm-lock.yaml - if: ${{ inputs.no-lockfile == 'true' }} - # The pnpm action: # - no support for volta # - no support for cache From c9788160c97437b1f872502e27072928784d2288 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Tue, 12 Sep 2023 17:02:39 -0400 Subject: [PATCH 2/2] Update README.md --- README.md | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/README.md b/README.md index 5594f62..828f92e 100644 --- a/README.md +++ b/README.md @@ -68,16 +68,6 @@ Passes through any args directly to `pnpm install`. args: '--ignore-scripts --fix-lockfile' ``` -### `no-lockfile` - -Boolean flag useful for tossing out the lockfile for testing if in-range floating dependency changes have accidentally broken things. - -```yaml -- uses: wyvox/action-setup-pnpm@v2 - with: - no-lockfile: true -``` - ## Why? [`pnpm/action-setup`](https://github.com/pnpm/action-setup/) can install dependencies on its own, but then no cache is used from [`actions/setup-node`](https://github.com/actions/setup-node).