Skip to content

Commit 87264e5

Browse files
authored
Merge pull request #406 from wunderio/feature/simplify-pr-template
QAG-44: Simplify the PR template
2 parents cf6c51f + ad900a3 commit 87264e5

File tree

1 file changed

+8
-45
lines changed

1 file changed

+8
-45
lines changed

.github/pull_request_template.md

Lines changed: 8 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,52 +1,15 @@
1-
# Link to ticket:
1+
## Ticket QAG-XXX
22

3-
[Add link to ticket] (if automatic linking is not used)
3+
## Changes
44

5-
# Changes proposed in this PR:
5+
- [Explain what changes were made in this PR]
66

7-
[Explain what was done and why. You can also add screenshots here if it helps.]
7+
## Testing
88

9-
# How to test
9+
Enviroment: [Feature environment URL]
1010

11-
## Testing in feature environment:
11+
Login: [`drush uli` command]
1212

13-
[Add link to feature environment]
14-
https://[BRANCH-NAME].[PROJECT-NAME].dev.wdr.io/
13+
Instructions:
1514

16-
[Add command how to get admin login url to the feature environment]
17-
`ssh www-admin@[BRANCH-name]-shell.[PROJECT-NAME] -J [email protected] "drush uli"`
18-
19-
## Local testing
20-
21-
_Detail custom setup instructions if any - any drush commands, content reindexing, specific user to use, etc._
22-
23-
git fetch && git checkout <branch>
24-
lando composer install
25-
lando drush cim -y
26-
lando drush cr
27-
28-
## Testing steps
29-
30-
_Testing scenario goes here._
31-
32-
1. Do this.
33-
2. Go there.
34-
3. Validate that xyz is working.
35-
36-
# Best practices:
37-
38-
<details>
39-
<summary><h3>Accessibility:</h3></summary>
40-
<p>
41-
This project must support WCAG accessibility level AA <em>(edit this according to the requirements of your project)</em>. To ensure this standard is met, remember to:
42-
43-
- Perform automated checks using a tool such as Wave or SiteImprove.
44-
- Test keyboard navigation: are all parts of the UI navigable using only the keyboard? Is the tab order logical? Can popups, menus etc be dismissed with the escape key?
45-
- Test responsiveness, scaling and text reflow.
46-
- Make sure no accessibility issues exist on either desktop or mobile views.
47-
- If you have time, test with a screen reader such as VoiceOver (macOS), NVDA (Windows), or Orca (Linux).
48-
49-
Use the [Accessibility Testing Cheat Sheet](https://intra.wunder.io/info/accessibility-group/accessibility-testing-cheat-sheet) for information on how to run these tests.
50-
51-
</p>
52-
</details>
15+
- [Step by step instructions to test the changes]

0 commit comments

Comments
 (0)