Skip to content

Users shouldn't be emailed needlessly #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 of 3 tasks
sersorrel opened this issue Aug 1, 2019 · 0 comments
Open
2 of 3 tasks

Users shouldn't be emailed needlessly #12

sersorrel opened this issue Aug 1, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@sersorrel
Copy link
Contributor

sersorrel commented Aug 1, 2019 •
edited
Loading

People already get too much email; we don't want to make the problem worse.

  • Reminders are not very intelligent – when running over a very short timeframe, people get emails telling them to submit their project when the system isn't even available to them yet.
  • Reminders can be sent very close together when running over a short timeframe (e.g. 14-day and 7-day reminders being sent simultaneously, if the deadline is set for less than a week away at rotation creation).
  • The Graduate Office is bcc'd into every email – is this actually what they want? (also: do users expect that the Graduate Office can e.g. read feedback from supervisors to students, given the access controls the backend imposes on that data?)
@sersorrel sersorrel added the enhancement New feature or request label Aug 1, 2019
sersorrel added a commit that referenced this issue Aug 2, 2019
@sersorrel
Use one job with multiple triggers for reminders
acd31ba 
Previously, one job would be scheduled for each "pester point" of a
deadline. Combined with the very long misfire_grace_time, this would
result in several reminders being sent simultaneously if they were
scheduled in the past, and in that case the notification would also
state the wrong number of days left (since the delta was hardcoded).

Now, each deadline's reminders are contained within a single job, which
is triggered at several predefined dates relative to the deadline. The
offset between the job and the deadline is calculated when the reminder
is sent, and if two reminders are scheduled to run simultaneously (e.g.
the 14-day and 7-day reminders), only the most recent reminder will be
sent (see #12).

Fixes #7.
@sersorrel sersorrel mentioned this issue Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sersorrel