Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the .settings-field-control wrap element and use the class on the actual field #23

Closed
felixarntz opened this issue May 29, 2017 · 1 comment
Closed

Remove the .settings-field-control wrap element and use the class on the actual field #23

felixarntz opened this issue May 29, 2017 · 1 comment
Assignees
@felixarntz
Labels
Semantic Markup
Milestone
WCEU-Prototype

Comments

@felixarntz
Copy link
Contributor

As discussed in today's meeting (see https://wordpress.slack.com/archives/C02RQBWTW/p1496073615671126), let's remove the unnecessary .settings-field-control element. That class should instead be used on the field element/s itself.

Note that this class name will definitely not be the name that we'll eventually use, but the name change is part of another discussion.
@felixarntz felixarntz self-assigned this May 29, 2017
@felixarntz felixarntz added this to the WCEU-Prototype milestone May 29, 2017
This was referenced May 29, 2017
Closed
Merged
@felixarntz
Copy link
Contributor Author

Closed through #32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixarntz felixarntz

Labels
Semantic Markup
Projects
None yet
Milestone
WCEU-Prototype
Development

No branches or pull requests
1 participant
@felixarntz