Skip to content

Homework Review Week 1 #1

@rohni

Description

@rohni

Hi Wouter,
Nice work. Everything works and no eslint errors. The code is clear and easy to read.
Good work!
Below are some points I ran into while going through each file.
step1.js

  • impressive number of languages. ;-)
    step4.js
  • you are missing the second part of the exercise. Did you forget to push it? You are supposed to assign a new string value to the variable and then repeat the first two steps with this new value.
    step5.js
  • I would use the variable values rather than hard-coding the numbers in again.
    i.e. console.log(Math.max(z, a));
    rather than console.log(Math.max(7.25, 7));
    step6.js
  • You logged what you thought the value of the empty array would be, but not what it actually is
  • You did not log the animal array before adding the pig.
    step8.js
  • let carBrand = ['bmw', ' volvo', 'toyota']; because it is an array (i.e. a collection of values) you should give it a plural name. e.g. carBrands
  • for bonus marks: You could have included the two values for the "not same type" statements. 😄
    step10.js
  • While there are no greater or lesser values of infinity (well actually in discrete mathematics there are, but that is not handled by the javascript interpreter. 😉 ), you can compare whether two infinities are equal, and in javascript they are considered equal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions