[BE] refactor: reviewRequestCode를 받는 api를 reviewGroupId를 받도록 변경 #1183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
ReviewGroup
응답 시, id를 응답하지 않아서 우선reviewRequestCode
를 사용하도록 임시조치 했습니다.reviewGroupId
를 사용하도록 변경했습니다.🔥 어떻게 해결했나요 ?
reviewGroupId
를 사용할 수 있게,/v2/groups/summary
의 응답으로reviewGroupId
를 포함하도록 했습니다.reviewRequestCode
로 받던 api를 모두reviewGroupId
로 변경했습니다.📝 어떤 부분에 집중해서 리뷰해야 할까요?
groupId
였는데, 코드 내에서는 명칭을 통일하는 것이 좋을 것 같아reviewGroupId
로 했습니다. 혹시groupId
가 더 나으려나요?reviewGroupId
를 포함해야 하는 부분이 더 있을까요?📚 참고 자료, 할 말