Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition while rendering pipeline commit #4537

Closed
3 tasks done
xoxys opened this issue Dec 8, 2024 · 4 comments · Fixed by #4746
Closed
3 tasks done

Race condition while rendering pipeline commit #4537

xoxys opened this issue Dec 8, 2024 · 4 comments · Fixed by #4746
Labels
bug Something isn't working ui frontend related

Comments

@xoxys
Copy link
Member

xoxys commented Dec 8, 2024

Component

web-ui

Describe the bug

Bildschirmaufzeichnung.vom.2024-12-08.20-56-36.mp4

Sometimes pipeline. is rendered instead of the commit hash. I guess that's a race condition during data loading from pinia. What I'm wondering about it, this only happens while a user is logged in. If the pipeline list is loaded as unauthenticated, everything seems to be working as intended.

Steps to reproduce

Reload the pipeline list multiple times.

Expected behavior

No response

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-d0e4a176f1"}

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@xoxys xoxys added bug Something isn't working ui frontend related labels Dec 8, 2024
@zc-devs
Copy link
Contributor

zc-devs commented Dec 9, 2024

Authenticated
Screenshot 2024-12-09 200315

Unauthenticated
Screenshot 2024-12-09 200853

  1. Requests for pipelines per repo I have. Wasn't a case on 2.8.
  2. Request for current active repo.

@xoxys
Copy link
Member Author

xoxys commented Jan 19, 2025

@xoxys
Copy link
Member Author

xoxys commented Jan 19, 2025

https://github.com/woodpecker-ci/woodpecker/pull/3806/files#r1921575001

AFAIK SQL this was a syntax error, but not sure.

Please double-check that with all DBs. I'm having a similar issue in my message rework PR, and there it is always working with some DBs, but not with the others.

Original author @qwerty287

@xoxys
Copy link
Member Author

xoxys commented Jan 19, 2025

I can reproduce the SQL error in sqlite

Image

Will try to find a workaround while keeping the escaped syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants