Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow badges to include more than just push events #4505

Open
3 tasks done
petersone-netic opened this issue Dec 3, 2024 · 8 comments
Open
3 tasks done

Allow badges to include more than just push events #4505

petersone-netic opened this issue Dec 3, 2024 · 8 comments
Labels
enhancement improve existing features server

Comments

@petersone-netic
Copy link

petersone-netic commented Dec 3, 2024

Component

web-ui

Describe the bug

We have a good state build, but the WEB UI shows a bad build result badge:
image

We have newer seen this problem before!

Steps to reproduce

...don't know...

Expected behavior

No response

System Info

{
"source": "https://github.com/woodpecker-ci/woodpecker",
"version": "2.7.3"
}

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@petersone-netic petersone-netic added the bug Something isn't working label Dec 3, 2024
@xoxys
Copy link
Member

xoxys commented Dec 3, 2024

Is the status wrong in your example, or the badge in the upper right?

@petersone-netic petersone-netic changed the title Wrong state icon Wrong badge icon Dec 3, 2024
@petersone-netic
Copy link
Author

Is the status wrong in your example, or the badge in the upper right?

Title + description updated.

@qwerty287
Copy link
Contributor

The badge is intentionally limited to the push event.

@xoxys
Copy link
Member

xoxys commented Dec 3, 2024

The badge is intentionally limited to the push event.

According to the screenshot, the last successful build is a commit to master (should match the push to default branch limitation) and should be reflected in the badge status.

@qwerty287
Copy link
Contributor

It's a cron build, not a push build

@xoxys
Copy link
Member

xoxys commented Dec 3, 2024

Ah, because of the clock symbol I see 👍

@petersone-netic
Copy link
Author

The badge is intentionally limited to the push event.

Hmm... why?
No matter the trigger of the pipeline, the badge should express the state of the pipeline (like the first word in the badge).
We have an dashboard where we intentionally monitor the state of our pipelines.

@qwerty287
Copy link
Contributor

I think it's good with this filter, because cron and push pipelines can be different. And mostly people use the badge for the push pipelines.
What would be good though is an option to change that.

@qwerty287 qwerty287 added enhancement improve existing features and removed bug Something isn't working labels Dec 8, 2024
@qwerty287 qwerty287 changed the title Wrong badge icon Allow badges to include more than just push events Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

No branches or pull requests

3 participants