Gitea: Personal repos not being shown?

[pat-s]

Forge: Gitea

So far I only worked with repos in orgs.
I tried to enable a private repo now but it doesn't come up when clicking "add repository" which essentially just invokes /api/user/repos AFAIK.
I logged in and out again, changed the log level to "debug" but still can't infer why it doesn't show up.

I don't have any restrictions set on the server in WOODPECKER_ORGS or similar. And I'd suspect that personal repos should always appear for the respective logged-in user?

This is a bit embarrassing but I might be missing something obvious here?

next-baaf8b97e1

[qwerty287]

What do you mean by "private" repo? A repo owned by yourself (and not an org) or really a private repo with limited visibility?

[qwerty287]

Something must be off with the syncing from Gitea (API only gives 200 as return but it doesn't return all repos I have access to.

So the gitea API does not return all repos, only those that are displayed in woodpecker? Or do you mean woodpecker's API?

[pat-s]

I assume that the Gitea SDK within WP does not return all repos (which is why I think #2705 might help but I can't build the PR images atm :/). Haven't yet checked with the Gitea API directly, but good point, I should check that next.

[mzampetakis]

You could also try to run a local woodpecker server and debug through appropriate logging. Alternatively you could check Gitea's API directly for its response.

[pat-s]

So, here we go: user/repos of the Gitea API does not return the questionable repos as well.
Super strange, as I created them and can push to them directly 😄
Gitea 1.20.5

So good news: it seems not be a WP issue and also not an issue of the Gitea SDK.

[mzampetakis]

Great finding! So if you find or open any relevant Gitea issue please mention it here for the case that someone else faces the same problem.

[qwerty287]

So this has been reported upstream: go-gitea/gitea#27891

I'm closing this one as we can't fix it.

[pat-s]

I meanwhile found out that it's a Gitea pagination issue. I can retrieve the repos via the Gitea UI when applying some pagination. By default, only the first 50 repos seem to be returned.

The following issues will explain this: https://gitea.com/gitea/go-sdk/issues/507

Maybe we incorporated the issues with the gitea skd upgrade in #2464. There is no changelog for 0.16 but a lot of commits and some which tackle pagination like https://gitea.com/gitea/go-sdk/pulls/573. Maybe changes are needed in the WP WRT to Gitea pagination.

The issue might only appear if a user has access to a lot of repos (e.g. when being the admin of a large instance, like it is the case in the references case of mine).

[pat-s]

Narrowed it down between Sept 3 (working) and Sept 8 (failing). There are 7 commits in this range with most of them being docs-only, build-only or translations. The main ones in question are

• 85e157b
• 8a517a8

[qwerty287]

Yes that's it. It's the second one you listed there.

Reason: Probably you have some archived repos? If no, the commit is not the issue (would be really weird then though). If yes: The pagination utils must receive the full response as they compare it to the len of the first response. If it's smaller (-> last page), it finishes. If some repos are filtered out, this happens already on a page that's not the last one because the len of the returned list is smaller than the first response.

I can send fix for this, but I don't know when I get the time for this (I'm writing this from my phone...).

[pat-s]

Yes that makes sense and also matches my debugging results: I tracked it down to #2374 and the

			if repo.GetArchived() {
				continue
			}

line. Removing it, makes things work again. I can send a quickfix-revert for now until a proper fix is ready.

[pat-s]

What a relief! I was already getting crazy about this one and it blocked our operations quite a bit as no new repos could be added 😅

[qwerty287]

The proper fix would just be to move this outside of the pagination func and iterate over all items in the final list instead and only keep the non-archived