-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide extensibility to allow for compatibility with marketplace plugins #1515
Comments
Cross linking over to woocommerce/woocommerce#29535 for discoverability and potential coordination. 🙂 |
Hi all... I had a customer asking about this today. And given that this issue originally dates back to 2018... is there any update? |
Hi there! I have a customer in ZD-7352678 asking about Apple Pay compatibility with Smart Coupons, it looks like the original issue was closed in favor of this one, is there any movement on this or should we advise customers it's not compatible at this point? Original issue that led me here |
We also encountered an issue with our Smart Coupons plugin affecting custom fields on the checkout page. When utilizing GPay/Apple Pay, the Checkout form data does not include information from these custom fields. More details here (#2969) For now, we have fixed the same issue in the Smart Coupons plugin by implementing some workaround. But for a proper fix, would be better if appropriate hooks are added in the GPay/Apple Pay checkout functions or any other way which would enable extending checkout form data by third-party plugins just like the default WooCommerce plugin does. Any ETA for this? |
Hi, |
Is your feature request related to a problem? Please describe.
This is a follow up to #566 at the request of @loranallensmith
There is explicit Product Addons support built in now it seems, but otherwise, there's currently no way for the request buttons to work on the single product page for more advanced product types or customized products. This impacts 2 of my plugins: Name Your Price and Mix and Match Products...(as well as Product Bundles, Composites, and probably still some of the other plugins listed in #566)
For example, in Name Your Price... a user enters a price and that becomes the price of the product, which is currently not possible. So there are several blockages for working with the payment request buttons:
Describe the solution you'd like
I think multiple things need to happen to make this a flexible framework that can be extended as needed by other plugins. This is just the minimum things I can think right now:
<form>
inputs to relay via ajaxajax_add_to_cart()
that allows for the manipulation that allows for the manipulation of$cart_item_data
param inadd_to_cart()
*This may not be necessary... would need to see if the hooks inadd_to_cart()
itself are sufficient if the form data gets passed along in the$_POST
but seems like to could be helpful.Describe alternatives you've considered
I've added code to my plugins to explicitly disable the payment request buttons for products using my plugins, which seems a shame because that's a cool feature. I am willing to write the compatibility code on my side but currently there's no framework to make that possible.
While cross-compatibility is never fun, it's my opinion that compatibility between plugins in the marketplace is a huge selling point.
The text was updated successfully, but these errors were encountered: