check to raise error when non-standard utf-8 #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
requested changes
Feb 17, 2025
| @@ -323,6 +324,19 @@ def publish_from_csv(path: Path, new_topic: str = None) -> None: | |||
| LOGGER.debug(f'Publishing station list from {path}') | |||
| station_list = [] | |||
| with path.open() as fh: | |||
There was a problem hiding this comment.
with path.open() as fh:
try:
_ = fh.readlines()
except UnicodeDecodeError as err:
msg = f'Invalid utf-8 in station metadata file: {err}'
LOGGER.error(msg)
raise RuntimeError(msg)
fh.seek(0)
reader = csv.DictReader(fh)
|
@alhelguera to add test data/CI integration. |
tomkralidis
requested changes
Mar 29, 2025
| - name: add Brazil wrongly encoded station data and check for error message | ||
| env: | ||
| STATION_METADATA: /data/wis2box/metadata/station/brazil.csv | ||
| run: | |
There was a problem hiding this comment.
We should not be encoding test logic in CI. This test should be in put forth in tests/integration/test_workflow.py instead.
There was a problem hiding this comment.
@tomkralidis, I disagree with your comment you asked Alberto to write the test in CI in your previous request and this test is based on command-line logic to demonstrate that the user receives a clear error when ingesting stations from the command-line, we should not put this in tests/integration/test_workflow.py
tomkralidis
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catching the UTF-8 decoding error to give a better error message