Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues affecting compositor usage #45

Open
WillPower3309 opened this issue Apr 20, 2024 · 2 comments
Open

Fix some issues affecting compositor usage #45

WillPower3309 opened this issue Apr 20, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@WillPower3309
Copy link
Member

A few points from the scenefx patch notes on dwl:

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

NOTE: Blur doesn't work on windows with opacity set (opacity_active, opacity_inactive)

NOTE: In DWL's Makefile scenefx must be placed before wlroots, e.g. PKGS = scenefx wlroots wayland-server ...

@wochap
Copy link

wochap commented Apr 21, 2024

Hi, I'm the author of the scenefx patch

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Regarding the note above, I just wanted to point out that DWL uses wlr_scene_subsurface_tree_set_clip to prevent apps from overflowing their available space, and that the usage of wlr_scene_subsurface_tree_set_clip with scenefx causes some GTK apps to look cut off.

Screenshoots

Here, I used the wlr_scene_subsurface_tree_set_clip function to clip all apps at 250x250
Personally, my guess is that wlr_scene_subsurface_tree_set_clip doesn't work as expected for GTK3 apps that have size hints
BTW, DWL doesn't listen to size hints

Shadow off:

Shadow on:

@WillPower3309 WillPower3309 added this to the scenefx 1.0 milestone Apr 23, 2024
@WillPower3309
Copy link
Member Author

Hi, I'm the author of the scenefx patch

NOTE: Some GTK apps are being cut off when they have shadows enabled. You can use the shadow_ignore_list option to prevent shadows from being rendered on those apps

Regarding the note above, I just wanted to point out that DWL uses wlr_scene_subsurface_tree_set_clip to prevent apps from overflowing their available space, and that the usage of wlr_scene_subsurface_tree_set_clip with scenefx causes some GTK apps to look cut off.

Screenshoots

Here, I used the wlr_scene_subsurface_tree_set_clip function to clip all apps at 250x250
Personally, my guess is that wlr_scene_subsurface_tree_set_clip doesn't work as expected for GTK3 apps that have size hints
BTW, DWL doesn't listen to size hints

Shadow off:

Shadow on:

Does #56 fix this? :)

@WillPower3309 WillPower3309 added the enhancement New feature or request label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants