Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Dec 3, 2025

TaskWPB-21977 [Android] Support for file updates

https://wearezeta.atlassian.net/browse/WPB-21977

What's new in this PR?

  • Show preview image for editable documents
  • Move refresh logic in a separate class
  • Add 30 seconds refresh logic for currently visible attachments with isEditSupported = true

@sbakhtiarov sbakhtiarov force-pushed the feat/cell-asset-refresh branch from 1105ce7 to 3ce7c09 Compare December 8, 2025 10:41
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 54.23729% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.50%. Comparing base (3a4b1b1) to head (3ce7c09).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...l/messagetypes/multipart/CellAssetRefreshHelper.kt 60.00% 16 Missing and 2 partials ⚠️
...getypes/multipart/MultipartAttachmentsViewModel.kt 35.71% 8 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (54.23%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4460      +/-   ##
===========================================
+ Coverage    47.43%   47.50%   +0.06%     
===========================================
  Files          536      537       +1     
  Lines        18127    18186      +59     
  Branches      3068     3074       +6     
===========================================
+ Hits          8599     8639      +40     
- Misses        8602     8613      +11     
- Partials       926      934       +8     
Files with missing lines Coverage Δ
...messagetypes/multipart/MultipartAttachmentsView.kt 0.00% <ø> (ø)
...getypes/multipart/MultipartAttachmentsViewModel.kt 56.96% <35.71%> (-5.54%) ⬇️
...l/messagetypes/multipart/CellAssetRefreshHelper.kt 60.00% <60.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4b1b1...3ce7c09. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants