Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Nested color values does not work for Multi-Root WS #68

Open
phoenisx opened this issue Sep 4, 2022 · 0 comments
Open

[Bug] Nested color values does not work for Multi-Root WS #68

phoenisx opened this issue Sep 4, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@phoenisx
Copy link
Contributor

phoenisx commented Sep 4, 2022

Describe the bug
Nested variable declarations do not get evaluated for color values, where one of the parent CSS source file is present in multiple folder settings.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Multi Root project, and define two folders (f1 and f2) in it.
  2. cssvar settings for both these folders would look something like the following:
// f1/.vscode/settings.json
{
  "cssvar.files": ["../node_modules/open-props/open-props.min.css"],
  "cssvar.ignore": []
}
// f2/.vscode/settings.json
{
  "cssvar.files": ["../node_modules/open-props/open-props.min.css", "theme*.css"],
  "cssvar.ignore": [],
}
  1. As you can see both f1 and f2 folders depend on variables provided by open-props.css and are defined in both folder's settings
  2. Intellisense for CSS variables in one of these folders (f2 for example) is not provided, even though open-props is declared in f2 folder's settings.

Expected behavior
Intellisense should work in both f1 and f2 folders, for open-props CSS variables.

Additional context
This is happening because a CSS source file is evaluated only once, unless it is modified later. Since open-props is served from node-modules, and is less likely to get updated, it isn't added to f2 intellisense providers.

@phoenisx phoenisx added the bug Something isn't working label Sep 4, 2022
@phoenisx phoenisx self-assigned this Sep 4, 2022
@phoenisx phoenisx modified the milestone: 2.3.2 Sep 16, 2022
@phoenisx phoenisx added this to the 2.6.0 milestone Oct 17, 2022
@phoenisx phoenisx mentioned this issue Nov 1, 2022
8 tasks
@phoenisx phoenisx modified the milestones: 2.6.0, v3.0 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant