Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat all code with standard coding style #31

Open
williamkapke opened this issue Jun 30, 2016 · 3 comments · May be fixed by #34
Open

Reformat all code with standard coding style #31

williamkapke opened this issue Jun 30, 2016 · 3 comments · May be fixed by #34

Comments

@williamkapke
Copy link
Owner

Somehow I used tabs when I created these files and it's really annoying haha. Sorry everyone.

I'd prefer to just use https://www.npmjs.com/package/standard

PR that converts everything would be AMAZING!

@yorkie yorkie linked a pull request Sep 23, 2016 that will close this issue
@StefanScherer
Copy link
Collaborator

Just a friendly notice that we have forked your repo to have some additions published for our projects. During that work we decided to reformat all the code to fit our eslint configuration where we also found some potential issues in the code base, add CI with Circle and AppVeyor, added some first unit tests, ...
The fork lives at https://github.com/sealsystems/node-ipp
Please let me know what do you think of this fork or if we should collaborate in your repo.

@williamkapke
Copy link
Owner Author

Your fork looks great!

Yes, the code needs some love. Really- it needs collaborators. If you (or others) are interested, I'd love to hand the project/module off to a community that:

  1. knows WAY more than I do :P
  2. can collaborate on the best way to evolve/enhance it

LMK!

/cc @michaelrsweet @wifiprintguy

@StefanScherer
Copy link
Collaborator

Thank you.

I'll check with my team next week how we can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants