Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonsensical behavior on attempt to share already saved diff, causing deletion never asked for #141

Open
php4fan opened this issue Apr 12, 2021 · 3 comments

Comments

@php4fan
Copy link

php4fan commented Apr 12, 2021

Steps to reproduce I:

  1. Go to https://editor.mergely.com/
  2. Enter some text on both sides
  3. Go to File->Share and click "Save for sharing"
  4. Do File->Share again

Expected: nothing much should happen. Maybe copy the url to the clipbpoard or tell me that the current diff is already saved and the url for sharing it is in my very address bar

Observed: This prompt:

image

and of course the "Delete permanently" does delete the diff. But I never asked to. I clicked on "Share".

Steps to reproduce II:

  1. Go to https://editor.mergely.com/
  2. Enter some text on both sides
  3. Go to File->Share and click "Save for sharing"
  4. Further edit at least one side
  5. Do File->Share again

Expected:
There are a few reasonable options here. What File->Share should accomplish in this scenario is to save the new diff and update the URL. But I was editing a previously saved one so I should probably get some sort of warning.
Let's say that at step 2 I had some texts in the editor and after step 3 it got saved as editor.mergely.com/ABCDE.
The simplest sensible behavior that I can think of for what happens after step 5 is that:

  • the new diff gets saved with a new id
  • the url in the browser's address bar gets updated to editor.mergely.com/FGHIJ
  • optionally (but very recommended) a popup or flash message shows up alerting me that the url has changed and that the URL of the old diff that I previously saved is editor.mergely.com/ABCDE.

No deletion should be involved

Observed:
The same nonsense as in case I:
image

@wickedest
Copy link
Owner

On issue 1, a diff was already shared. It is a public document. The idea of "Share" was to be similar to a lot of other web applications - as a dialog to control the share. Since there is no user access, and no way to un-share a public document, the only option possible is to delete it. I could do away with the dialog and add "trash" icon that does the delete.

On issue 2, I agree an update option would be good to have.

I'll leave this ticket open as an enhancement request.

@php4fan
Copy link
Author

php4fan commented Apr 18, 2021

Since there is no user access, and no way to un-share a public document, the only option possible is to delete it.

I get that, but then in that situation I would expect the "File->Share" item to be replaced by (or become) "File->Delete".

On issue 1, a diff was already shared. It is a public document. The idea of "Share" was to be similar to a lot of other web applications - as a dialog to control the share.

Ohhhhhhhhh I guess I get it now: you mean the word "Share" in File->Share is not meant as an imperative, meaning "Do share this now", but rather as "Options related to sharing". If that is the case, instead of "Share" you may want to call it "Manage sharing", "sharing options" or something like that.

@waldyrious
Copy link

instead of "Share" you may want to call it "Manage sharing", "sharing options" or something like that.

Or simply "Sharing..." (ellipses are commonly used to indicate that a menu item opens a dialog instead of performing an action immediately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants