Modification of the pod observation #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The podRailed case seemed pretty useless to me as the message and reason was always empty so I got a lot of meaningless events. I also think that any Pod-Failure that is not due to failed containers will show up as events and get better reported as such. Another disadvantage of the former implementation was, that it reported only ever one container failure per pod.
This introduces a name mangleing like the sentry-kubernets implementation does for more aggressive issue grouping.
The message often contains unique information like container-ids or node names causing basically no grouping to happen.
…VENT_LEVELS... - Leaving SKIP_EVENT_LEVELS unset Defaults to old behavior, "normal" type events will be skipped - Setting SKIP_EVENT_LEVELS to empty No event type will be skipped - Setting SKIP_EVENT_LEVELS to a comma separated event type list like "SKIP_EVENT_LEVELS=normal,warning" All events of those types will be skipped. The filtering mechanism is case-insensitive, so "normal,warning" is the same as "nOrMal,WARning".
Fix Pod Term Detection and Make SkipLevels Configurable
feat: favor a namespace's skipLevel annotation for the global skipLevel env
added: - NS annotation secunet.sentry/skip-event-reasons: allow configuration of skip event reasons per namespace - env SKIP_EVENT_REASONS: global skip by reason config if NS has no skip config annotation - Pod annotation secunet.sentry/ignore-pod-updates=true: allows for suppression of pod update event handling through the forwarder changed: - skip config declaration format now supports specifying a resource type before a criteria: [involved object type:]criteria[,...] E.g. normal,Pod:warning,Service:error See: parseSkipConfig(...) at skip.go:71
feat: skip by reason and skip pod updates...
|
@wichert what's your opionion on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a RFC as I'm aware that it changes the current behavior quite a bit - and I'm fine to keep it as a fork. Still I'm curious what others think of these changes: