Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lint check for trailing whitespace to the make script #208

Open
domenic opened this issue Oct 26, 2016 · 4 comments
Open

Add a lint check for trailing whitespace to the make script #208

domenic opened this issue Oct 26, 2016 · 4 comments

Comments

@domenic
Copy link
Member

domenic commented Oct 26, 2016

@tobie, I think, keeps checking in trailing whitespace.

@tobie
Copy link
Collaborator

tobie commented Oct 26, 2016

Oh, you mean for empty lines? Yeah, I tend to prefer when empty lines keep the same indentation level as their context. As my text editor is set to display invisible characters, it make the structure stand out a bit more. I'm not very consistent about it, however.

If that's an issue for some, I'll just stop doing it. Do feel free to tap me on the shoulder if you see more of it in the future, though.

@tobie
Copy link
Collaborator

tobie commented Oct 26, 2016

Oh, it's actually worse than I thought. Left some real trailing whitespace around. I guess I'm getting old. :D

@tobie
Copy link
Collaborator

tobie commented Oct 26, 2016

Fixed trailing whitespace in 9280415.

@annevk
Copy link
Member

annevk commented Oct 27, 2016

I think you should clear all trailing whitespace as most specifications follow that convention and having to configure your editor on a per-specification-basis would be annoying. (Although admittedly we have that problem to some extent by not having consistent formatting conventions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants