-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a definition of multimap #198
Comments
It would be interesting to see if a specialized data structure would simplify defining Headers/URLSearchParams/FormData a lot. Currently they use a list underneath, which is somewhat reasonable too. |
Headers went back to single-map, right? |
Ah, right, |
I drafted a pull request for this, but for some reason can't get bikeshed to process it (even the online version at https://api.csswg.org/bikeshed/). The output page appears to contain the single character "#". I"m running Windows 10, so it might be a line ending problem, anyone familiar with this? |
I haven't had this problem myself; I also use Windows 10. But yes, please make sure you are using LF line endings; our gitattributes and editorconfig should be enforcing that. Maybe first try compiling the spec as-is, to make sure that works? |
@domenic, same result when I paste the original into https://api.csswg.org/bikeshed/ (as text.) If I use the upload file option, I get this message: FATAL ERROR: Found unmatched text macro [SNAPSHOT-LINK]. Correct the macro, or escape it with a leading backslash. |
Right, you need to set the SNAPSHOT-LINK macro, per the makefile. |
Can you recommend what Make tool I should be using on Windows? |
You'll need https://curl.haxx.se/download.html. You can either copy and paste the commands from the Makefile, or use http://gnuwin32.sourceforge.net/packages/make.htm. (We should probably have this stuff documented in the contributing.md...) |
Adjust language in definition of ordered map. Fixes: whatwg#198
Got it. Thanks. |
Hmm, now I'm wondering if pairs is/should be a synonym for multimap. |
For clarity, if we adopt multimap it has to simplify these standards:
I think that's all the multimaps we have in the platform. |
The INFRA spec currently has a good definition of ordered map, but its definition requires key uniqueness. Sometimes the uniqueness constraint isn't desirable. For example whatwg/fetch describes header-list as multimap, saying:
I would suggest it is useful to define multimap in the general whatwg/infra spec. The language above, making multimap an ordered list of key-value pairs, seems perfectly acceptable to me.
The text was updated successfully, but these errors were encountered: