Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-webkit-text-fill-color and list marker #71

Open
upsuper opened this issue Dec 30, 2016 · 5 comments
Open

-webkit-text-fill-color and list marker #71

upsuper opened this issue Dec 30, 2016 · 5 comments

Comments

@upsuper
Copy link
Member

upsuper commented Dec 30, 2016

See the following code:

<!DOCTYPE html>
<style>
:root { color: red; -webkit-text-fill-color: green; }
li::before, li::after { content: "##"; }
</style>
<ol><li>hello</li></ol>
<ul><li>hello</li></ul>

Should the list markers use color or -webkit-text-fill-color?

Currently all browsers use color for the list markers, but it seems inconsistent to me, because in theory, like ::before and ::after, list markers are just some pseudo elements contain some generated content. I think it should use the same color as other text.
@chenpighead
Copy link

IMHO, I prefer that the list markers should use the same color as other text.

IIRC, I implemented -webkit-text-fill-color just for the compatibility reason, so I was targeting to be agree with WebKit and Blink.

@miketaylr could you (or someone) help gather feedback from WebKit and Blink?

@miketaylr
Copy link
Member

@tabatkins, @grorg any thoughts here?

@tabatkins
Copy link
Contributor

Yeah, if we assume text-fill stuff exists, then bullets probably should use them for their colors.

@grorg
Copy link

grorg commented Jan 6, 2017

Agreed.

@upsuper
Copy link
Member Author

upsuper commented Jan 6, 2017

Filed bug 1329052 for Gecko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@grorg @miketaylr @upsuper @tabatkins @chenpighead