Skip to content

Commit 2001cc5

Browse files
committed
Adding tabIndex values related to WV-937. Upgraded some npm packages.
1 parent f6012ae commit 2001cc5

File tree

4 files changed

+72
-58
lines changed

4 files changed

+72
-58
lines changed

package-lock.json

+41-50
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+6-6
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"@wdio/mocha-framework": "^8.35.0",
7070
"@wdio/protocols": "^8.32.0",
7171
"@wdio/spec-reporter": "^8.32.4",
72-
"axios": "^1.6.0",
72+
"axios": "^1.8.3",
7373
"babel-loader": "^9.1.3",
7474
"babel-plugin-styled-components": "^2.1.4",
7575
"chai": "^4.3.7",
@@ -109,8 +109,8 @@
109109
},
110110
"dependencies": {
111111
"@emotion/is-prop-valid": "^1.1.2",
112-
"@emotion/react": "^11.11.4",
113-
"@emotion/styled": "^11.13.5",
112+
"@emotion/react": "^11.14.0",
113+
"@emotion/styled": "^11.14.0",
114114
"@loadable/component": "^5.16.4",
115115
"@mui/icons-material": "^5.16.14",
116116
"@mui/lab": "^5.0.0-alpha.96",
@@ -142,7 +142,7 @@
142142
"puppeteer": "^22.10.0",
143143
"react": "~17.0.2",
144144
"react-bootstrap": "^1.6.4",
145-
"react-confetti": "^6.1.0",
145+
"react-confetti": "~6.1.0",
146146
"react-copy-to-clipboard": "^5.1.0",
147147
"react-dom": "~17.0.2",
148148
"react-fullstory": "^1.4.0",
@@ -154,9 +154,9 @@
154154
"react-helmet-async": "^1.3.0",
155155
"react-phone-number-input": "^3.4.10",
156156
"react-player": "^2.16.0",
157-
"react-rewards": "^2.0.4",
157+
"react-rewards": "^2.1.0",
158158
"react-router-dom": "^5.3.4",
159-
"react-router-dom-v5-compat": "^6.28.2",
159+
"react-router-dom-v5-compat": "^6.29.0",
160160
"react-share": "^4.4.1",
161161
"react-slick": "^0.30.2",
162162
"react-svg": "^14.1.9",

src/js/components/Filter/FilterBaseSearch.jsx

+7-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ class FilterBaseSearch extends Component {
241241
}
242242
// console.log('FilterBaseSearch render');
243243
return (
244-
<BigAndroidClickableTarget onClick={() => this.bigAndroidClick(isSearching, alwaysOpen)}>
244+
<BigAndroidClickableTarget id="androidClickableTarget" onClick={() => this.bigAndroidClick(isSearching, alwaysOpen)}>
245245
<SearchWrapper
246246
brandBlue={theme.palette.primary.main}
247247
isSearching={isSearching}
@@ -250,26 +250,32 @@ class FilterBaseSearch extends Component {
250250
>
251251
<IconButton
252252
classes={{ root: classes.iconButtonRoot }}
253+
id="searchIcon"
253254
onClick={(!isAndroid() && !alwaysOpen) ? this.toggleSearch : undefined}
254255
size="large"
255256
aria-label="Search Button"
257+
tabIndex={0}
256258
>
257259
<Search classes={{ root: searchIconClasses }} />
258260
</IconButton>
259261
<Separator isSearching={isSearching} alwaysOpen={alwaysOpen} />
260262
<InputBase
261263
classes={{ input: inputBaseInputClasses, root: inputBaseRootClasses }}
264+
id="searchInput"
262265
inputRef={(input) => { this.searchInput = input; }}
263266
onChange={this.handleSearch}
264267
value={searchText}
265268
onFocus={() => focusTextFieldAndroid('FilterBaseSearch')}
266269
onBlur={blurTextFieldAndroid}
267270
placeholder="Search"
271+
tabIndex={isSearching ? 0 : -1}
268272
/>
269273
<Closer
274+
id="searchCloseButton"
270275
isSearching={isSearching}
271276
onClick={(isSearching || !alwaysOpen) ? this.toggleSearch : undefined}
272277
showCloser={isSearching}
278+
tabIndex={isSearching ? 0 : -1}
273279
>
274280
<IconButton classes={{ root: classes.iconButtonRoot }} size="large">
275281
<Close classes={{ root: classes.closeIconRoot }} />

src/js/pages/Ballot/Ballot.jsx

+18-1
Original file line numberDiff line numberDiff line change
@@ -1513,10 +1513,20 @@ class Ballot extends Component {
15131513
<div className="ballot_filter_btns">
15141514
<Badge
15151515
badgeContent={ballotItemsByFilterType.length}
1516-
classes={{ badge: classes.badge, colorPrimary: classes.badgeColorPrimary }}
1516+
classes={{
1517+
badge: classes.badge,
1518+
colorPrimary: classes.badgeColorPrimary,
1519+
root: classes.badgeRoot,
1520+
}}
15171521
color={(oneTypeOfBallotItem === raceLevelFilterType && !isSearching) ? 'primary' : 'default'}
15181522
id={`ballotBadgeDesktop-${oneTypeOfBallotItem}`}
15191523
invisible={ballotItemsByFilterType.length === 0}
1524+
onFocus={(e) => {
1525+
e.currentTarget.classList.add(classes.badgeFocused);
1526+
}}
1527+
onBlur={(e) => {
1528+
e.currentTarget.classList.remove(classes.badgeFocused);
1529+
}}
15201530
>
15211531
{ballotChip}
15221532
</Badge>
@@ -1741,6 +1751,13 @@ const styles = (theme) => ({
17411751
color: theme.palette.primary.main,
17421752
},
17431753
},
1754+
badgeFocused: {
1755+
outline: `2px solid ${theme.palette.primary.main}`,
1756+
outlineOffset: '2px',
1757+
},
1758+
badgeRoot: {
1759+
display: 'inline-block', // This ensures the focus outline wraps around the entire badge
1760+
},
17441761
unselectedBadgeColorPrimary: {
17451762
background: 'rgba(0, 0, 0, .2)',
17461763
color: '#333',

0 commit comments

Comments
 (0)