Skip to content
This repository has been archived by the owner on Jun 24, 2018. It is now read-only.

Invalid check for method? #1

Open
mekras opened this issue Jul 28, 2011 · 3 comments
Open

Invalid check for method? #1

mekras opened this issue Jul 28, 2011 · 3 comments

Comments

@mekras
Copy link

mekras commented Jul 28, 2011

I suppose that this line
https://github.com/westonruter/webforms2/blob/master/webforms2_src.js#L1525
contains an error. I think that valid code is:

if(el.checkValidity != undefined && !el.checkValidity())

and not:

if(!el.checkValidity() && el.checkValidity() != undefined)

@matthewslyman
Copy link

Opera's Javascript error console is indicating various errors with validation (even after Mekras' fix has been applied), when repetition is implemented as well as validation. See this article:
http://my.opera.com/hallvors/blog/show.dml/476181
...and this test page:
http://www.aaabit.com/products/calculation/bin-packing/

My test page has already been hacked to make it work in Opera. It would be nice to make it work properly in every major browser (including those popular in Eastern Europe). Can you help?

@matthewslyman
Copy link

@mekras: #ERROR# : Your fix appears to prevent forms from being submitted, at least in Chrome. Have you tried your own fix, and tested the results on a variety of browsers?

@mekras
Copy link
Author

mekras commented Aug 3, 2011

I've tried it in Firefox 5. And I think this is just a one error in a chain. After spent some time trying to find out other errors I've refused to use this library. So I have no complete fix :-(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants