Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 docs(demo): basic arabic translation #390

Merged
merged 7 commits into from
Feb 16, 2025
Merged

Conversation

TheAwiteb
Copy link
Collaborator

@TheAwiteb TheAwiteb commented Sep 19, 2024

Close #383

In this PR i'll be translating the entire blog to Arabic. The following is the translation progress:

  • Home page & social card
  • About page & social card
  • Privacy page (Doesn't have a social card)
  • Initial blog section, projects and archive

Projects

  • doteki & social card
  • git-sumi & social card
  • nani & social card
  • Streaming Royalties Calculator & social card
  • tabi & social card

Blog content

  • comments article & social card
  • custom-font-subset article & social card
  • customise-tabi article & social card
  • faq-languages article & social card
  • javascript article & social card
  • markdown article & social card
  • mastering-tabi-settings article & social card
  • security article & social card
  • shortcodes article & social card
  • social_cards article & social card
  • toc article & social card

Finishing touches

  • blog section social card
  • projects section social card
  • archive section social card

@TheAwiteb TheAwiteb added documentation Improvements or additions to documentation enhancement New feature or request i18n Internationalisation labels Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 4a7e045
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67b23aa082261b0008eb95b1
😎 Deploy Preview https://deploy-preview-390--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TheAwiteb TheAwiteb self-assigned this Sep 19, 2024
@welpo
Copy link
Owner

welpo commented Sep 19, 2024

Let me know if I can help!

@TheAwiteb
Copy link
Collaborator Author

Let me know if I can help!

I'll, everything seems clean so far.

@welpo
Copy link
Owner

welpo commented Sep 21, 2024

If you'd like, I think it would make sense to make you code owner of *.ar.* files in this PR. I believe this line should work:

*.ar.* @TheAwiteb

@TheAwiteb
Copy link
Collaborator Author

Hey @welpo, I'm no longer interested in translating the theme documentation into Arabic.

I'm still very interested in maintaining the Arabic language support for the theme itself and would be happy to continue contributing in that area.

Thanks!

@TheAwiteb TheAwiteb removed their assignment Jan 19, 2025
@welpo
Copy link
Owner

welpo commented Jan 20, 2025

Alright! Understandable.

I'm thinking it would be useful, to ensure LTR compatibility, to have at least the landing page in Arabic, and maybe one short post (to test metadata, for example). I could translate with AI, but if you have something ready that can work better, let me know.

What do you think?

@TheAwiteb
Copy link
Collaborator Author

TheAwiteb commented Jan 20, 2025

and maybe one short post (to test metadata, for example). I could translate with AI

I'm okay with that. I will review it

but if you have something ready that can work better

The landing page, about page, and privacy page have all been translated to Arabic in this PR. You can use them

@welpo
Copy link
Owner

welpo commented Feb 16, 2025

Hey @TheAwiteb!

I've added one post and one project, and cleaned up some stuff.

To me, it looks ready to merge. What do you think?

You can see it live in the demo.

Thanks!

@welpo welpo marked this pull request as ready for review February 16, 2025 09:35
@welpo welpo self-requested a review as a code owner February 16, 2025 09:35
@welpo welpo changed the title 🌐 feat: arabic translation for the entire blog 🌐 docs(demo): basic arabic translation Feb 16, 2025
Copy link
Collaborator Author

@TheAwiteb TheAwiteb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will take long to review then update it, I'll update it. Then you can merge the PR

@welpo
Copy link
Owner

welpo commented Feb 16, 2025

I have fixed the errors you mentioned.

Please don't worry about the translation being perfect! As long as it's not awful, I'm happy to merge

Thanks a lot!

@TheAwiteb
Copy link
Collaborator Author

Let's Go 🚀

@TheAwiteb
Copy link
Collaborator Author

I added an Arabic poem and used force_text_direction. Also add a code tag in Arabic

@welpo
Copy link
Owner

welpo commented Feb 16, 2025

Awesome! Merging now :) Thank you so much~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request i18n Internationalisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arabic translation for the theme features
2 participants