Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RC loss function was not implemented correctly. #18

Open
wehs7661 opened this issue May 23, 2020 · 0 comments
Open

The RC loss function was not implemented correctly. #18

wehs7661 opened this issue May 23, 2020 · 0 comments

Comments

@wehs7661
Copy link
Owner

In the current implementation of the RC loss function, we use scikit-learn to perform kernel density estimation (along with k-fold cross-validation for the optimization of the bandwidth), which returns a NumPy array instead of a Pytorch tensor. Since there is no information about the gradient of the RC loss function, the current Boltzmann generator was not able to backpropagate and the RC loss function did not actually influence the result of training. Since there are no built-in functions for kernel density estimation and k-fold cross-validation, the way of solving this issue might be coding up RC loss in using PyTorch instead of NumPy-based packages.

Currently, the development of the project has been paused, so this issue might not be addressed in the short term. We, therefore, file an issue here as a record/reminder of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant