Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCPeerConnection createOffer Promise resolves with undefined object #1028

Closed
3 tasks done
mdelete opened this issue Apr 6, 2020 · 3 comments
Closed
3 tasks done
Labels

Comments

@mdelete
Copy link

mdelete commented Apr 6, 2020

Please read first!

Please use discuss-webrtc for general technical discussions and questions.

  • I have provided steps to reproduce (e.g. a link to a jsfiddle)
  • I have provided browser name, version and adapter.js version
  • This issue only happens when adapter.js is used

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed.

Versions affected

Browser name including version (e.g. Chrome 64.0.3282.119)

Brave Version 1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit)

adapter.js (e.g. 6.1.0)

7.5.1

Description

When trying to create an offer for a new RTCPeerConnection the Promise resolves with an undefined value.

Steps to reproduce

rtcPeerConnection.createOffer({
  offerToReceiveAudio: 1,
  offerToReceiveVideo: 1
});

Expected results

Promise {<resolved>: Object { type: "offer", ... }}

Actual results

Promise {<resolved>: undefined}

@fippo
Copy link
Member

fippo commented Apr 14, 2020

Can't reproduce, that code works for me. If you can reproduce can you try without adapter?

@fippo fippo added the needs-feedback the issue needs feedback label May 18, 2020
@mdelete
Copy link
Author

mdelete commented Jun 2, 2020

Issue seems to be the browser blocking fingerprinting. What's weird in this case is, that the unblocking-menu of Brave does not show this, sometimes isn't even accessible. So definitely a browser issue, but maybe calls for better error-handling. Will investigate further.

@fippo
Copy link
Member

fippo commented Jul 12, 2020

feross/simple-peer#701 has a pretty good description of the issue.

@fippo fippo added bug and removed needs-feedback the issue needs feedback labels Sep 7, 2020
@fippo fippo closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants