Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add development section on dropdown action order #2429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shrinks99
Copy link
Member

Closes #2428

Caveats

@Shrinks99 Shrinks99 added the documentation Improvements or additions to documentation label Feb 27, 2025
@Shrinks99 Shrinks99 requested review from SuaYoo and emma-sg February 27, 2025 03:58
@Shrinks99 Shrinks99 changed the title Add developemnt docs section on dropdown action order docs: a developemnt docs section on dropdown action order Feb 27, 2025
@Shrinks99 Shrinks99 changed the title docs: a developemnt docs section on dropdown action order docs: add developemnt section on dropdown action order Feb 27, 2025
@@ -0,0 +1,21 @@
# Actions Dropdowns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might call this "Action Menus"?

Actions related only to the current page (eg: remove archived item from collection)
---
Actions related to editing the object (eg: edit workflow config, edit item metadata)
Other actions related to the current object (eg: run crawl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be worth including navigation to related items here, like we do for archived items where you can go to the related workflow from here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real answer here is they should be discouraged! Will note that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah? I could see it being useful sometimes. Maybe we have a consistent submenu for related items? Go To Related > Workflow

Copy link
Member Author

@Shrinks99 Shrinks99 Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're considered a (in my opinion small) accessibility sin: https://www.makethingsaccessible.com/guides/site-navigation-is-not-an-aria-menu/

Not bad enough that we should never ever do it, but bad enough that it should be avoided.

@emma-sg emma-sg changed the title docs: add developemnt section on dropdown action order docs: add development section on dropdown action order Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Dropdown order implementation
2 participants