Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

json file and js file in same folder causes problems #85

Closed
danday74 opened this issue Nov 8, 2017 · 2 comments
Closed

json file and js file in same folder causes problems #85

danday74 opened this issue Nov 8, 2017 · 2 comments

Comments

@danday74
Copy link

danday74 commented Nov 8, 2017

When I put a JSON file called overview.json in a dyson folder and have a overview.js file (any file with the same name) dyson fails to pick up the .js file

I have used this pattern to load my .json into the .js file

See this example here ... https://github.com/danday74/mock-server/tree/master/rest/mock/me/get

Note that the code in the example works because the .json file has a different name to the .js file

Not sure if this will be something you plan to fix but I thought I'd raise an issue :)

@webpro
Copy link
Owner

webpro commented Nov 8, 2017

Thanks, @danday74. Maybe you can open a PR to fix this? :-)

@webpro
Copy link
Owner

webpro commented Nov 13, 2017

On second thought, I'm leaning against "fixing" this. I think it's not a bug, it's a feature: to load JSON files as configuration.

So my recommendation would be to put such templates outside the "dyson folder".

I hope you agree :-)

@webpro webpro closed this as completed Nov 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants