Update documentation examples to ES6 #7636 #7704
Conversation
|
@DeekshaVarshney123 is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
DeekshaVarshney123
force-pushed
the
feat/es6-docs-update
branch
3 times, most recently
from
81afd9c to
51ea1c3
Compare
|
Hello Webpack Maintainers, I'm confirming that the Link Check, Unit Test, and Lint checks are all failing due to a dependency lockfile error. The logs show: This indicates that either the My code changes (ES Modules syntax updates) are clean and ready for review once the tests pass. Thank you for your help! |
package.json
Outdated
| "dependencies": { | ||
| "@docsearch/react": "^3.9.0", | ||
| "@react-spring/web": "^9.7.5", | ||
| "ajv": "^6.12.6", |
There was a problem hiding this comment.
no need to add these deps
There was a problem hiding this comment.
Thanks for the review! I've removed the unnecessary ajv dependency and pushed the fix. I'm happy to see all checks are now passing!
One quick question regarding the scope of Issue #7636:
I've currently updated two guides. Should I proceed with updating the remaining configuration, concept, and guide files using the same ES Modules syntax pattern for all webpack.config.js blocks?
The PR is now clean and ready for your final review.
DeekshaVarshney123
force-pushed
the
feat/es6-docs-update
branch
from
51ea1c3 to
81bb7aa
Compare
2 participants
Hello Webpack Team,
This Pull Request addresses Issue #7636 by updating documentation examples to use ES Modules syntax (
import/export default) instead of CommonJS (require/module.exports).🛠️ Current Changes
For an initial review, I have only updated two key guides in the
guidessection:src/content/guides/getting-started.mdxsrc/content/guides/asset-management.mdx💡 Request for Review
Could you please review these changes to ensure:
webpack.config.jscode blocks in these two guides.diffblocks where necessary) aligns with the documentation contribution standards.If the changes are satisfactory, I will proceed to update the remaining documentation files for Issue #7636. If any modifications or additional steps are required, please let me know.
Thank you for your time!