Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Compatibility with new readable-stream #96

Open
guimard opened this issue Dec 2, 2019 · 3 comments
Open

Compatibility with new readable-stream #96

guimard opened this issue Dec 2, 2019 · 3 comments

Comments

@guimard
Copy link

guimard commented Dec 2, 2019

Hi,

to use recent readable-stream, I had to patch your module:

--- a/index.js
+++ b/index.js
@@ -22,11 +22,11 @@
 exports.readline                                       = null;
 exports.repl                                           = null;
 exports.stream                                         = require.resolve('stream-browserify');
-exports._stream_duplex                         = require.resolve('readable-stream/duplex.js');
-exports._stream_passthrough                    = require.resolve('readable-stream/passthrough.js');
-exports._stream_readable                       = require.resolve('readable-stream/readable.js');
-exports._stream_transform                      = require.resolve('readable-stream/transform.js');
-exports._stream_writable                       = require.resolve('readable-stream/writable.js');
+exports._stream_duplex                         = require.resolve('readable-stream/lib/_stream_duplex.js');
+exports._stream_passthrough                    = require.resolve('readable-stream/lib/_stream_passthrough.js');
+exports._stream_readable                       = require.resolve('readable-stream/lib/_stream_readable.js');
+exports._stream_transform                      = require.resolve('readable-stream/lib/_stream_transform.js');
+exports._stream_writable                       = require.resolve('readable-stream/lib/_stream_writable.js');
 exports.string_decoder                         = require.resolve('string_decoder');
 exports.sys                                                    = require.resolve('util/util.js');
 exports.timers                                         = require.resolve('timers-browserify');
@mitchell-frost
Copy link

Are these changes supposed to be made to the module? If so, can I work on this?

@guimard
Copy link
Author

guimard commented Jul 16, 2020

Hi @michael-ciniawsky, this is needed with readable-stream ≥ 3

@niksy
Copy link

niksy commented Nov 13, 2021

If anyone is still facing this problem, I’ve created updated version of node-libs-browser which updates these API changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants