Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate on webpack built-in logger #358

Open
alexander-akait opened this issue Jun 9, 2020 · 4 comments · May be fixed by #361
Open

migrate on webpack built-in logger #358

alexander-akait opened this issue Jun 9, 2020 · 4 comments · May be fixed by #361
Labels
semver: Minor Status: Ready for PR

Comments

@alexander-akait
Copy link
Member

alexander-akait commented Jun 9, 2020 •
edited
Loading

Issue description

Migrate on built-in webpack logger API https://webpack.js.org/api/logging/

Technical info

  • Webpack Bundle Analyzer version: latest
  • Webpack version: any
  • Node.js version: any
  • npm/yarn version: any
  • OS: any

Debug info

Allow to filter and configure logger options from configuration(s) + allow to collect logs from stats

What other Webpack plugins were used?

Irrelevant
@valscion
Copy link
Member

This would make webpack-bundle-analyzer only compatible with webpack v4.39.0 and forwards. Right now we're compatible with even webpack v3 if I remember correctly, so this would be a major version bump.

@alexander-akait
Copy link
Member Author

We can't avoid breaking change using:

const logger = logging.getLogger ? logging.getLogger('webpack-bundle-analyzer') : oldLogger;

@valscion
Copy link
Member

Ah cool idea! That would be a possible idea.

@jamesgeorge007
Copy link
Member

I would love to give it a shot 🙌

@jamesgeorge007 jamesgeorge007 linked a pull request Jun 17, 2020 that will close this issue
Draft
@valscion valscion mentioned this issue Oct 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver: Minor Status: Ready for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate to consume webpack built-in logger jamesgeorge007/webpack-bundle-analyzer
3 participants
@valscion @alexander-akait @jamesgeorge007