Generate report only if build was successfull

[alphanull]

Right now, when my build fails the bundle analyzer runs nonetheless, spitting out hundreds of lines like "Error parsing bundle asset ..."

It would be much nicer if I could configure this plugin to run only after a successful build

[valscion]

Hmm but what if only some part was unsuccessful but the output still contains valid bundles? Is there a hybrid scenario possible where only some part of the webpack build failed but webpack-bundle-analyzer could still work correctly?

[alphanull]

At least in my case, when my build fails no files are generated at all. And since I clear my dist folder before each build, I get those messages I mentioned:

Error parsing bundle asset "/path/to/file.js": no such file

And at the end:

No bundles were parsed. Analyzer will show only original module sizes from stats file.

Maybe we have another problem, I mean why is this plugin trying to analyze those non existing files in the first place?

[valscion]

It is because the webpack stats object generated by webpack lists the bundles that would be output and webpack-bundle-analyzer tries to then parse those files.

webpack-bundle-analyzer/src/BundleAnalyzerPlugin.js

Lines 33 to 38 in 34b6223

	apply(compiler) {
	this.compiler = compiler;
	const done = (stats, callback) => {
	callback = callback || (() => {});
	stats = stats.toJson(this.opts.statsOptions);

webpack-bundle-analyzer/src/BundleAnalyzerPlugin.js

Line 54 in 34b6223

actions.push(() => this.generateStaticReport(stats));

webpack-bundle-analyzer/src/BundleAnalyzerPlugin.js

Lines 119 to 120 in 34b6223

	async generateStaticReport(stats) {
	await viewer.generateReport(stats, {

webpack-bundle-analyzer/src/viewer.js

Line 117 in 34b6223

async function generateReport(bundleStats, opts) {

webpack-bundle-analyzer/src/viewer.js

Line 127 in 34b6223

const chartData = getChartData({logger, excludeAssets}, bundleStats, bundleDir);

webpack-bundle-analyzer/src/viewer.js

Lines 189 to 199 in 34b6223

	function getChartData(analyzerOpts, ...args) {
	let chartData;
	const {logger} = analyzerOpts;
	try {
	chartData = analyzer.getViewerData(...args, analyzerOpts);
	} catch (err) {
	logger.error(`Could't analyze webpack bundle:\n${err}`);
	logger.debug(err.stack);
	chartData = null;
	}

webpack-bundle-analyzer/src/analyzer.js

Line 20 in 34b6223

function getViewerData(bundleStats, bundleDir, opts) {

webpack-bundle-analyzer/src/analyzer.js

Lines 50 to 60 in 34b6223

	for (const statAsset of bundleStats.assets) {
	const assetFile = path.join(bundleDir, statAsset.name);
	let bundleInfo;
	try {
	bundleInfo = parseBundle(assetFile);
	} catch (err) {
	const msg = (err.code === 'ENOENT') ? 'no such file' : err.message;
	logger.warn(`Error parsing bundle asset "${assetFile}": ${msg}`);
	continue;
	}

webpack-bundle-analyzer/src/analyzer.js

Line 9 in 34b6223

const {parseBundle} = require('./parseUtils');

webpack-bundle-analyzer/src/parseUtils.js

Lines 10 to 11 in 34b6223

	function parseBundle(bundlePath) {
	const content = fs.readFileSync(bundlePath, 'utf8');

[th0r]

We can probably do nothing if there are compilation errors? @valscion what do you think?

[valscion]

We can probably do nothing if there are compilation errors? @valscion what do you think?

Yeah, that might make sense. It's likely that we won't be able to do much with the resulting bundles (if there are any) after compilation errors anyway.

[alphanull]

Yeah, doing nothing after any errors (including errors resulting from multiconfigs) would be nice. Of course this also could be a configuration setting, so if users want to have a report even after having errors, they still can do that. But I think in most cases, it makes no sense to generate a report when the build fails anyways.

[valscion]

Nah, I'd prefer not adding new configuration options for this

[alphanull]

OK, I also would be fine with no additional options

[thomas-darling]

This still appears to be an issue.
It really makes no sense to generate a report for a failed build, and those messages create a lot of noise in the logs, which distracts from the real errors. Any chance we could have those messages suppressed when the build fails?

[fregante]

Same here, it's incredibly annoying to see webpack-bundle-analyzer pile on webpack errors and still open a useless report file in the browser.

By default it should just detect the failure and output just "Webpack failed, no soup for you!", especially when it cannot find the assets at all and it shows:

Error parsing bundle asset "/path/to/file.js": no such file

[snitin315]

PR welcome :)