Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withFields - list values not checking "dirty" flag correctly #7

Open
adrians5j opened this issue May 26, 2020 · 0 comments
Open

withFields - list values not checking "dirty" flag correctly #7

adrians5j opened this issue May 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@adrians5j
Copy link
Member

When having a list of values, assigning anything to the field will actually mark the field as dirty, even if a list was completely the same.

This is mainly because fields receive new array instances, and currently that will make the field consider itself dirty, which is in most cases just wrong.

We need to implement a smarter way of checking the received values, and only mark the field dirty when that's truly the case.

@adrians5j adrians5j added the bug Something isn't working label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant