Update PHPUnit

- flip missordered arguments
- remove ->expects($this->any()) without special meaning
- XML config: remove redundant default value, remove outdated comment, update schema location

Author: MalteWunsch

phpunit.xml.dist

@@ -1,9 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<!-- http://phpunit.de/manual/4.1/en/appendixes.configuration.html -->
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.1/phpunit.xsd"
-         backupGlobals="false"
+         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/8.5/phpunit.xsd"
          bootstrap="vendor/autoload.php"
 >
     <testsuites>
@@ -17,5 +15,4 @@
             <directory>src</directory>
         </whitelist>
     </filter>
-
-</phpunit>
+</phpunit>

test/Webfactory/Slimdump/Config/TableTest.php

@@ -129,7 +129,7 @@ public function testDumpTriggerDefaultSetting()
         $xmlElement = new \SimpleXMLElement($xml);
         $table = new Table($xmlElement);
 
-        $this->assertEquals($table->getDumpTriggersLevel(), Table::DEFINER_NO_DEFINER);
+        $this->assertEquals(Table::DEFINER_NO_DEFINER, $table->getDumpTriggersLevel());
         $this->assertTrue($table->isTriggerDumpRequired());
     }
 

test/Webfactory/Slimdump/Database/DumperTest.php

@@ -33,7 +33,7 @@ protected function setUp(): void
 
     public function testDumpSchemaWithNormalConfiguration()
     {
-        $this->dbMock->expects($this->any())->method('fetchColumn')->willReturn('CREATE TABLE statement');
+        $this->dbMock->method('fetchColumn')->willReturn('CREATE TABLE statement');
 
         $this->dumper->dumpSchema('test', $this->dbMock);
         $output = $this->outputBuffer->fetch();
@@ -46,12 +46,12 @@ public function testDumpDataWithFullConfiguration()
     {
         $pdoMock = $this->getMockBuilder(\stdClass::class)->addMethods(['setAttribute'])->getMock();
 
-        $this->dbMock->expects($this->any())->method('getWrappedConnection')->willReturn($pdoMock);
+        $this->dbMock->method('getWrappedConnection')->willReturn($pdoMock);
 
-        $this->dbMock->expects($this->any())
+        $this->dbMock
             ->method('fetchColumn')
             ->willReturn(2);
-        $this->dbMock->expects($this->any())
+        $this->dbMock
             ->method('fetchAll')
             ->willReturnCallback(function ($query) {
                 if (false !== strpos($query, 'SHOW COLUMNS')) {
@@ -69,13 +69,13 @@ public function testDumpDataWithFullConfiguration()
 
                 throw new \RuntimeException('Unexpected fetchAll-call: '.$query);
             });
-        $this->dbMock->expects($this->any())
+        $this->dbMock
             ->method('quote')
             ->willReturnCallback(function ($value) {
                 return $value;
             });
 
-        $this->dbMock->expects($this->any())->method('query')->willReturn([
+        $this->dbMock->method('query')->willReturn([
             [
                 'col1' => 'value1.1',
                 'col2' => 'value1.2',