[FEATURE] Add event GlossarySyncDone

[koehnlein]

First of all, thanks for all of your DeepL extensions, they help me a lot.

It would be pretty nice for my use case to have an event, when the glossary sync was done.

[sbuerk]

Thanks @koehnlein for the pull-request.

In general I don't hestitate to accept an event on places if that helps others, but in this case I would abstain from appling and accepting this directly.

The reason is, that my collegue is preparing the deepltranslate-core towards API v3 and I don't have an oversight what changes may required in this area and if the event make sense in the current form. We keep the pull-request open so we can revisit this when we have a deeper insight where the road is going to be layed out.

Additionally, we need to check if a more finer event would also make sense to complete this and further if more context data in the event would be reasonable or use-full.

Beside that, and because it's missing in the pull-request/commit message, what is your exact use-case for what you are requesting this event. That would help us to understand your need and to help out if this is really the right way for your use-case or if we should provide something else.

So please be aware that this may eventually lay around the one or other day (week).

[sbuerk]

Suggested change

	EventDispatcher $eventDispatcher,
	EventDispatcherInterface $eventDispatcher,

It's common practice to use the EventDispatcherInterface as type declaration and not the concrete implementation. We strive to use interfaces over concrete implementation as much as possible, and refactor the code base over time if not
breaking over time - and if we have the time for it.

For new code we are having a eye on such things.

[koehnlein]

Changed it

[sbuerk]

Suggested change

	use TYPO3\CMS\Core\EventDispatcher\EventDispatcher;
	use Psr\EventDispatcher\EventDispatcherInterface;

Sorting needs to be checked after applining the change:

Build/Scripts/runTests.sh -s cgl

[koehnlein]

Changed it

[sbuerk]

Need to talk with my collegue, but I guess we are stating with private properties for now and using getter/getter&setters .. needs to be revisited and rethinked.

Coming back on this later.

[koehnlein]

I looked into other Events of your company's extensions and followed the coding style, I could find there.

• https://github.com/web-vision/deepltranslate-core/blob/7d0694698086337df2eddbc0715e45d6bfb82235/Classes/Event/DeepLGlossaryIdEvent.php#L23
• https://github.com/web-vision/deepltranslate-core/blob/7d0694698086337df2eddbc0715e45d6bfb82235/Classes/Event/DisallowTableFromDeeplTranslateEvent.php#L14
• https://github.com/web-vision/deepltranslate-core/blob/7d0694698086337df2eddbc0715e45d6bfb82235/Classes/Event/RenderLocalizationSelectAllowed.php#L16

But I'm fine if I should change it again.

[koehnlein]

Beside that, and because it's missing in the pull-request/commit message, what is your exact use-case for what you are requesting this event. That would help us to understand your need and to help out if this is really the right way for your use-case or if we should provide something else.

I would like to introduce further processings with glossary entries and set flags, depending if the were change in TYPO3 (I to this with a DataHandler hook) or if they are also synced to DeepL. For this second part, I need this event with the information which page ID was synced.