Coop header parsing null byte #25181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
arturjanc,
domenic,
foolip,
hemeryar,
jdm,
jgraham,
jugglinmike,
mikewest,
ParisMeuleman,
valenting and
zqzhang
|
Oh yeah, this is by design, but only Chrome implements it thus far I think. Edit: see whatwg/xhr#165. |
|
Aha, thanks @annevk! I see tests for fetch and XHR were added. Other kinds of loads with 0x00 might also be good to test, right? |
|
Yup, see #21019 for some of those. |
|
I guess it's also time to enshrine this in the specification given that it stuck in Chromium and others want this as well. |
|
Thanks. I'll close this, since the test introduced here is invalid. Is the spec change for HTTP? Is there an issue for this? |
|
It's whatwg/xhr#165 and it would be either HTTP or Fetch. And if it's HTTP, Fetch should probably still call it out as an assert or some such. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hexcles as per #20873 (comment) (which this PR is on top of, only the last commit here is new).
When looking at this again, it seems the connection rejection may be happening in Chromium, since this test is working in Firefox. That is, wptserve handles this fine.
The interesting URL is https://web-platform.test:8443/html/cross-origin-opener-policy/resources/coop-coep.py?coop=same-origin%00&coep=&channel=unspecified_to_SAME_ORIGIN_same-origin%00 (or whatever port you get with
wpt runorwpt serve)In Chrome, I get an error page: