You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A W(P)T may specify fuzziness parameters as either an inclusive range
[min, max], or a single expected value [1] (e.g., `totalPixels=30` means
exactly 30 pixels must be different for a test/reference to match).
This patch corrects a few tests that mistakenly reject exact matches
(i.e., maxDifference = totalPixels = 0) because they specify exact
nonzero parameters. WPT unfortunately doesn't interpret this as `0-<N>`,
even though this is almost always what we want in practice.
`run_web_tests.py` allowed these parameters to land because it ignores
fuzzy parameters when the image hashes match exactly. Now, to be
consistent with [1] and its implementation in wptrunner, only skip
diffing when exact matches are expected.
[1]: https://web-platform-tests.org/writing-tests/reftests.html#fuzzy-matching
Bug: 1254776
Change-Id: I868e571a891b2a570934d17dd605f42db22a0ddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908234
Reviewed-by: Weizhong Xia <[email protected]>
Commit-Queue: Jonathan Lee <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1206623}
0 commit comments