feat: enable buildCache by default #1334
Draft
+88
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
Timeless0911
November 13, 2025 12:03
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables buildCache by default in Rslib to improve build performance by leveraging Rspack's persistent caching capabilities.
Key Changes:
- Set
buildCache: trueas the default in Rslib's core configuration - Disable build cache in test environments to ensure consistent test results
- Update test snapshots to reflect the new cache configuration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/config.ts | Adds buildCache: true to the default performance configuration |
| tests/scripts/shared.ts | Explicitly disables buildCache in test environments with proper config spreading |
| packages/core/tests/snapshots/config.test.ts.snap | Updates snapshots to reflect cache configuration in experiments and performance settings |
| website/rspress.config.ts | Fixes builderConfig alias placement from resolve to source (unrelated bug fix) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
reviewed
Nov 13, 2025
chenjiahan
reviewed
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable
buildCacheby default in Rslib.Related Links
Checklist